Bug 1351409 - Remove animationiteration from legacy event listener test and re-enable that test. r=jmaher
☠☠ backed out by 3c1c19235a37 ☠ ☠
authorXidorn Quan <me@upsuper.org>
Thu, 21 Dec 2017 16:10:38 +1100
changeset 397137 8c912df2f3a5bdb67b4abcac25bb9e6e65de848a
parent 397136 3dd0966303ca6d6fd06e30aeda5bbbbe573d16a5
child 397138 bc1fb4f2b1149cf634134ef9fe34353b669264ec
push id33127
push useraiakab@mozilla.com
push dateThu, 21 Dec 2017 22:17:05 +0000
treeherdermozilla-central@d20967c26da5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1351409, 701445
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1351409 - Remove animationiteration from legacy event listener test and re-enable that test. r=jmaher According to :birtles, it is not guaranteed that animationiteration event will be fired. This event is sample-based rather than event-based, and such behavior has been clarified in CSS Animations Level 2: https://drafts.csswg.org/css-animations-2/#event-dispatch Also, Chromium has the same issue with this test: https://bugs.chromium.org/p/chromium/issues/detail?id=701445 MozReview-Commit-ID: KBCzkGHxbfc
testing/web-platform/meta/dom/events/EventListener-invoke-legacy.html.ini
testing/web-platform/tests/dom/events/EventListener-invoke-legacy.html
deleted file mode 100644
--- a/testing/web-platform/meta/dom/events/EventListener-invoke-legacy.html.ini
+++ /dev/null
@@ -1,3 +0,0 @@
-[EventListener-invoke-legacy.html]
-  type: testharness
-  disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1351409
--- a/testing/web-platform/tests/dom/events/EventListener-invoke-legacy.html
+++ b/testing/web-platform/tests/dom/events/EventListener-invoke-legacy.html
@@ -57,16 +57,15 @@ function setupTransition(elem) {
     elem.style.transition = 'color 30ms';
     requestAnimationFrame(function() {
       elem.style.color = 'green';
     });
   });
 }
 
 function setupAnimation(elem) {
-  elem.style.animation = 'test 30ms 2';
+  elem.style.animation = 'test 30ms';
 }
 
 runLegacyEventTest('transitionend', 'webkitTransitionEnd', "TransitionEvent", setupTransition);
 runLegacyEventTest('animationend', 'webkitAnimationEnd', "AnimationEvent", setupAnimation);
-runLegacyEventTest('animationiteration', 'webkitAnimationIteration', "AnimationEvent", setupAnimation);
 runLegacyEventTest('animationstart', 'webkitAnimationStart', "AnimationEvent", setupAnimation);
 </script>