Bug 802422 - Pay attention to the actual test result. r=terrence
authorSteve Fink <sfink@mozilla.com>
Fri, 12 Oct 2012 14:53:45 -0700
changeset 110566 8c22cd5e4f35d3866425ca2c32330fc287f1b82f
parent 110565 1eb12b546fad724310ec9b5538bc47700a4a784f
child 110567 ef8010af9fe64de113d0226b10523b47b09dd1a6
push id23700
push userryanvm@gmail.com
push dateThu, 18 Oct 2012 02:10:26 +0000
treeherdermozilla-central@5142bbd4da12 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersterrence
bugs802422
milestone19.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 802422 - Pay attention to the actual test result. r=terrence
js/src/tests/lib/results.py
--- a/js/src/tests/lib/results.py
+++ b/js/src/tests/lib/results.py
@@ -108,17 +108,17 @@ class ResultsSink:
             if self.options.tinderbox:
                 self.print_tinderbox_result('TEST-KNOWN-FAIL', output.test.path, time=output.dt, skip=True)
             self.counts['SKIP'] += 1
             self.n += 1
         else:
             result = TestResult.from_output(output)
 
             show = self.options.show
-            if self.options.failed_only and result == 'PASS':
+            if self.options.failed_only and result.result == 'PASS':
                 show = False
 
             if show and self.options.show_output:
                 print >> self.fp, '## %s: rc = %d, run time = %f' % (output.test.path, output.rc, output.dt)
 
             if show and self.options.show_cmd:
                 print >> self.fp, escape_cmdline(output.cmd)