Bug 820629 - animateTransform should not animate non-transform-type attributes (follow-up to correct type) r=dholbert
authorRobert Longson <longsonr@gmail.com>
Fri, 14 Dec 2012 17:16:43 +0000
changeset 116078 8afa0fd12d00acec7182b99a5e99042c156a5ed3
parent 116077 d8be8785e3a7da63748b0e5103026aa618e5aabd
child 116079 ff71c0ea0cb2ea48a8cbffd4578a1f1eb3428eb0
push id24043
push userryanvm@gmail.com
push dateSat, 15 Dec 2012 21:18:16 +0000
treeherdermozilla-central@c8a1314aa449 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs820629
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 820629 - animateTransform should not animate non-transform-type attributes (follow-up to correct type) r=dholbert
content/svg/content/src/nsSVGAnimateTransformElement.cpp
--- a/content/svg/content/src/nsSVGAnimateTransformElement.cpp
+++ b/content/svg/content/src/nsSVGAnimateTransformElement.cpp
@@ -38,17 +38,17 @@ public:
   // Element specializations
   bool ParseAttribute(int32_t aNamespaceID,
                         nsIAtom* aAttribute,
                         const nsAString& aValue,
                         nsAttrValue& aResult);
 
   // nsISMILAnimationElement
   virtual nsSMILAnimationFunction& AnimationFunction();
-  virtual bool GetTargetAttributeName(PRInt32 *aNamespaceID,
+  virtual bool GetTargetAttributeName(int32_t *aNamespaceID,
                                       nsIAtom **aLocalName) const;
 
   virtual nsXPCClassInfo* GetClassInfo();
 
   virtual nsIDOMNode* AsDOMNode() { return this; }
 };
 
 NS_IMPL_NS_NEW_SVG_ELEMENT(AnimateTransform)
@@ -114,17 +114,17 @@ NS_IMPL_ELEMENT_CLONE_WITH_INIT(nsSVGAni
 
 nsSMILAnimationFunction&
 nsSVGAnimateTransformElement::AnimationFunction()
 {
   return mAnimationFunction;
 }
 
 bool
-nsSVGAnimateTransformElement::GetTargetAttributeName(PRInt32 *aNamespaceID,
+nsSVGAnimateTransformElement::GetTargetAttributeName(int32_t *aNamespaceID,
                                                      nsIAtom **aLocalName) const
 {
   if (nsSVGAnimateTransformElementBase::GetTargetAttributeName(aNamespaceID,
                                                                aLocalName)) {
     return *aNamespaceID == kNameSpaceID_None &&
            (*aLocalName == nsGkAtoms::transform ||
             *aLocalName == nsGkAtoms::patternTransform ||
             *aLocalName == nsGkAtoms::gradientTransform);