Bug 1523562 [wpt PR 14832] - Revert "Reland "[PE] Fix background-image on ::first-line"", a=testonly
authorXianzhu Wang <wangxianzhu@chromium.org>
Thu, 31 Jan 2019 18:31:44 +0000
changeset 457973 8aed967f6e6367982dcba23d323b0a34da2fa418
parent 457972 f0c73aa8b4408ad765c5fb41ebd0fd15af421400
child 457974 9eb38c69446baadce8ca7840373eda1f909ade0c
push id35518
push useropoprus@mozilla.com
push dateFri, 08 Feb 2019 09:55:14 +0000
treeherdermozilla-central@3a3e393396f4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1523562, 14832, 921337, 921341, 920115, 918881, 1396154, 620921, 1403315, 621178, 1403316, 622298, 1407974, 622325
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523562 [wpt PR 14832] - Revert "Reland "[PE] Fix background-image on ::first-line"", a=testonly Automatic update from web-platform-tests Revert "Reland "[PE] Fix background-image on ::first-line"" This reverts commit f6facb87f009321e336fea1db249ad41f4116bb8. Reason for revert: Still can't ensure strictly paired AddClient/RemoveClient. Bug: 921337,921341 Original change's description: > Reland "[PE] Fix background-image on ::first-line" > > This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e. > > The original patch failed to call RemoveClient for the background-image > in the first line style. > > Original change's description: > > Revert "[PE] Fix background-image on ::first-line" > > > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688. > > > > Reason for revert: crbug.com/920115 > > > > Bug: 920115 > > > > Original change's description: > > > [PE] Fix background-image on ::first-line > > > > > > This CL ensures correct handling of background-image on ::first-line > > > from style change to paint invalidation. > > > > > > Bug: 918881 > > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154 > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#620921} > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 918881 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403315 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#621178} > > Bug: 920115, 918881 > Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1403316 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622298} TBR=wangxianzhu@chromium.org,futhark@chromium.org Change-Id: I6d31b858b2bf61bb123c6bdb09780f33e05b4878 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920115, 918881 Reviewed-on: https://chromium-review.googlesource.com/c/1407974 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#622325} -- wpt-commits: 9d21b523b4959f402769d58248e4587fda7f39ff wpt-pr: 14832
testing/web-platform/tests/css/css-backgrounds/background-image-first-line.html
testing/web-platform/tests/css/css-backgrounds/reference/background-image-first-line-ref.html
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-backgrounds/background-image-first-line.html
+++ /dev/null
@@ -1,19 +0,0 @@
-<!DOCTYPE html>
-<title>CSS Test: background-image applicability to ::first-letter</title>
-<link rel="help" href="http://www.w3.org/TR/css3-background/">
-<link rel="help" href="http://www.w3.org/TR/CSS21/selector.html#first-line-pseudo">
-<link rel="match" href="reference/background-image-first-line-ref.html">
-<meta name="flags" content="ahem image">
-<meta name="assert" content="background-image applicability to ::first-line">
-<style type="text/css">
-#content {
-  color: transparent;
-  font: 100px Ahem;
-}
-#content::first-line {
-  background-image: url("support/cat.png");  /* 98 w. by 99px h. */
-  background-repeat: no-repeat;
-}
-</style>
-<p>Test passes if cat image is visible.</p>
-<div id="content">X</div>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-backgrounds/reference/background-image-first-line-ref.html
+++ /dev/null
@@ -1,12 +0,0 @@
-<!DOCTYPE html>
-<meta name="flags" content="ahem image">
-<style type="text/css">
-#content {
-  color: transparent;
-  font: 100px Ahem;
-  background-image: url("../support/cat.png");  /* 98 w. by 99px h. */
-  background-repeat: no-repeat;
-}
-</style>
-<p>Test passes if cat image is visible.</p>
-<div id="content">X</div>