Bug 1088520 - Fix empty eclipse project generated on Linux. r=glandium
authorTing-Yu Lin <aethanyc@gmail.com>
Fri, 24 Oct 2014 03:11:00 +0200
changeset 212217 8a799dd8a11c147a6fbe21d6a9ec2873a2961af2
parent 212113 de805196bbc444667c983ff0180ff99d411a8a5b
child 212218 141ea70b1caf6bf42a2ac2e1c359de7ed9a93a02
push id27702
push userkwierso@gmail.com
push dateFri, 24 Oct 2014 22:05:50 +0000
treeherdermozilla-central@c70f62375f7d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1088520
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1088520 - Fix empty eclipse project generated on Linux. r=glandium Use "Gecko" with captical letter 'G' for both project dir and the project name in .project.
python/mozbuild/mozbuild/backend/cpp_eclipse.py
--- a/python/mozbuild/mozbuild/backend/cpp_eclipse.py
+++ b/python/mozbuild/mozbuild/backend/cpp_eclipse.py
@@ -22,18 +22,19 @@ from ..frontend.data import (
 class CppEclipseBackend(CommonBackend):
     """Backend that generates Cpp Eclipse project files.
     """
 
     def _init(self):
         CommonBackend._init(self)
 
         self._paths_to_defines = {}
+        self._project_name = 'Gecko'
         self._workspace_dir = self._get_workspace_path()
-        self._project_dir = os.path.join(self._workspace_dir, 'gecko')
+        self._project_dir = os.path.join(self._workspace_dir, self._project_name)
         self._overwriting_workspace = os.path.isdir(self._workspace_dir)
 
         self._macbundle = self.environment.substs['MOZ_MACBUNDLE_NAME']
         self._appname = self.environment.substs['MOZ_APP_NAME']
         self._bin_suffix = self.environment.substs['BIN_SUFFIX']
         self._cxx = self.environment.substs['CXX']
         # Note: We need the C Pre Processor (CPP) flags, not the CXX flags
         self._cppflags = self.environment.substs.get('CPPFLAGS', '')
@@ -194,17 +195,17 @@ class CppEclipseBackend(CommonBackend):
                 launch = launch.replace('@OBJDIR@', self.environment.topobjdir)
                 fh.write(launch)
 
         #TODO Add more launch configs (and delegate calls to mach)
 
     def _write_project(self, fh):
         project = PROJECT_TEMPLATE;
 
-        project = project.replace('@PROJECT_NAME@', 'Gecko')
+        project = project.replace('@PROJECT_NAME@', self._project_name)
         project = project.replace('@PROJECT_TOPSRCDIR@', self.environment.topsrcdir)
         fh.write(project)
 
     def _write_cproject(self, fh):
         cproject_header = CPROJECT_TEMPLATE_HEADER
         cproject_header = cproject_header.replace('@PROJECT_TOPSRCDIR@', self.environment.topobjdir)
         cproject_header = cproject_header.replace('@MACH_COMMAND@', os.path.join(self.environment.topsrcdir, 'mach'))
         fh.write(cproject_header)