Bug 823523 - Part 4 - Whitelist Samsung Honeycomb devices for Stagefright decoding - r=bjacob
authorChris Double <chris.double@double.co.nz>
Mon, 18 Feb 2013 13:36:17 +1300
changeset 122198 8a5523cc2812c8290d79ac419b0d80901ff84563
parent 122197 d5cb684d6b761a4ab841cb7656e26042f08521f2
child 122199 820dff9bdc55add3299ad566fb44070cd762b29b
push id24322
push userdbaron@mozilla.com
push dateMon, 18 Feb 2013 08:55:11 +0000
treeherdermozilla-central@0acbd06d48a9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbjacob
bugs823523
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 823523 - Part 4 - Whitelist Samsung Honeycomb devices for Stagefright decoding - r=bjacob
widget/android/GfxInfo.cpp
--- a/widget/android/GfxInfo.cpp
+++ b/widget/android/GfxInfo.cpp
@@ -378,16 +378,29 @@ GfxInfo::GetFeatureStatusImpl(int32_t aF
           cManufacturer.Equals("htc", nsCaseInsensitiveCStringComparator()) ||
           cManufacturer.Equals("samsung", nsCaseInsensitiveCStringComparator());
 
         if (!isWhitelisted) {
           *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DEVICE;
           return NS_OK;
         }
       }
+      else if (CompareVersions(mOSVersion.get(), "3.0.0") >= 0 &&
+          CompareVersions(mOSVersion.get(), "4.0.0") < 0)
+      {
+        // Honeycomb Samsung devices are whitelisted.
+        // All other Honeycomb devices are blacklisted.
+	bool isWhitelisted =
+          cManufacturer.Equals("samsung", nsCaseInsensitiveCStringComparator());
+
+        if (!isWhitelisted) {
+          *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DEVICE;
+          return NS_OK;
+        }
+      }
       else if (CompareVersions(mOSVersion.get(), "4.0.0") < 0)
       {
         *aStatus = nsIGfxInfo::FEATURE_BLOCKED_OS_VERSION;
         return NS_OK;
       }
       else if (CompareVersions(mOSVersion.get(), "4.1.0") < 0)
       {
         bool isWhitelisted =