Bug 491769 - add access key to the checkbox in the geolocation infobar. r=gavin
authorDoug Turner <dougt@meer.net>
Wed, 06 May 2009 16:32:37 -0700
changeset 28056 89574e2e0381399997b1cfdc1fdc3365d3d22f33
parent 28055 e4f29e0faf9aeffeb8d86d6fead4a56b84e34fab
child 28057 5fbc762eeeb1c8627ad2ed0a6517becac9f086aa
push id6867
push userdougt@mozilla.com
push dateWed, 06 May 2009 23:32:51 +0000
treeherdermozilla-central@89574e2e0381 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin
bugs491769
milestone1.9.2a1pre
Bug 491769 - add access key to the checkbox in the geolocation infobar. r=gavin
browser/components/nsBrowserGlue.js
browser/locales/en-US/chrome/browser/browser.properties
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -1114,16 +1114,17 @@ GeolocationPrompt.prototype = {
       // (eg, without the setTimeout), the "link"
       // element does not show up in the notification
       // bar.
       function geolocation_hacks_to_notification () {
 
         var checkbox = newBar.ownerDocument.createElementNS(XULNS, "checkbox");
         checkbox.className = "rememberChoice";
         checkbox.setAttribute("label", browserBundle.GetStringFromName("geolocation.remember"));
+        checkbox.setAttribute("accesskey", browserBundle.GetStringFromName("geolocation.remember.accesskey"));
         newBar.appendChild(checkbox);
 
         var link = newBar.ownerDocument.createElementNS(XULNS, "label");
         link.className = "text-link";
         link.setAttribute("value", browserBundle.GetStringFromName("geolocation.learnMore"));
 
         var formatter = Cc["@mozilla.org/toolkit/URLFormatterService;1"].getService(Ci.nsIURLFormatter);
         link.href = formatter.formatURLPref("browser.geolocation.warning.infoURL");
--- a/browser/locales/en-US/chrome/browser/browser.properties
+++ b/browser/locales/en-US/chrome/browser/browser.properties
@@ -177,16 +177,17 @@ geolocation.shareLocation=Share Location
 geolocation.shareLocation.accesskey=a
 geolocation.dontShareLocation=Don't Share
 geolocation.dontShareLocation.accesskey=o
 geolocation.siteWantsToKnow=%S wants to know your location.
 # LOCALIZATION NOTE (geolocation.learnMore): Use the unicode ellipsis char, \u2026,
 # or use "..." unless \u2026 doesn't suit traditions in your locale.
 geolocation.learnMore=Learn Moreā€¦
 geolocation.remember=Remember for this site
+geolocation.remember.accesskey=R
 
 # Phishing/Malware Notification Bar.
 # LOCALIZATION NOTE (notAForgery, notAnAttack)
 # The two button strings will never be shown at the same time, so
 # it's okay for them to have the same access key
 safebrowsing.getMeOutOfHereButton.label=Get me out of here!
 safebrowsing.getMeOutOfHereButton.accessKey=G
 safebrowsing.reportedWebForgery=Reported Web Forgery!