servo: Merge #18851 - Update WPT (from jdm:updatewpt4); r=jdm
authorPyfisch <pyfisch@gmail.com>
Thu, 12 Oct 2017 12:08:04 -0500
changeset 385919 892d9b753f1ab60973fd0aa84d18c89e8bf99a08
parent 385918 7dd785b2c20165d6cebd92e244ec18e2417c86f7
child 385920 e7f4ffe10569be04293a8195045cbc8f198209f6
push id32672
push userarchaeopteryx@coole-files.de
push dateFri, 13 Oct 2017 09:00:05 +0000
treeherdermozilla-central@3efcb26e5f37 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdm
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #18851 - Update WPT (from jdm:updatewpt4); r=jdm This syncs us with 524bea1dd8d0ad58733072bd4e8b8044042f589e from web-platform-tests. Source-Repo: https://github.com/servo/servo Source-Revision: 8171a5f7fe31a6b67a6a0ebcb25a024002a625bf
servo/python/servo/testing_commands.py
--- a/servo/python/servo/testing_commands.py
+++ b/servo/python/servo/testing_commands.py
@@ -491,24 +491,22 @@ class MachCommands(CommandBase):
         kwargs['test_list'].append(str('SKIP_TESTS'))
         kwargs['manifest_update'] = True
         return self.test_wpt(**kwargs)
 
     @Command('update-wpt',
              description='Update the web platform tests',
              category='testing',
              parser=updatecommandline.create_parser())
-    @CommandArgument('--patch', action='store_true', default=False,
-                     help='Create an mq patch or git commit containing the changes')
-    def update_wpt(self, patch, **kwargs):
+    def update_wpt(self, **kwargs):
         self.ensure_bootstrapped()
         run_file = path.abspath(path.join("tests", "wpt", "update.py"))
-        kwargs["no_patch"] = not patch
+        patch = kwargs.get("patch", False)
 
-        if kwargs["no_patch"] and kwargs["sync"]:
+        if not patch and kwargs["sync"]:
             print("Are you sure you don't want a patch?")
             return 1
 
         run_globals = {"__file__": run_file}
         execfile(run_file, run_globals)
         return run_globals["update_tests"](**kwargs)
 
     @Command('filter-intermittents',