Backed out changeset ece60a1dbd9d (bug 1675774) for performance regressions (bug 1676630)
authorAndreea Pavel <apavel@mozilla.com>
Wed, 11 Nov 2020 16:52:12 +0200
changeset 556746 88f6a6c2a328a0abc4421e5428b9b1c7a527c8b3
parent 556745 df3b944e4f3f4df63d41f9f6004cb2883583b541
child 556747 79e739e76a267caee680ab0589bbca5811cc7667
push id37941
push userncsoregi@mozilla.com
push dateThu, 12 Nov 2020 03:32:32 +0000
treeherdermozilla-central@cadd17ae918b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1675774, 1676630
milestone84.0a1
backs outece60a1dbd9d62d4330aafb15c6404a112a0033d
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset ece60a1dbd9d (bug 1675774) for performance regressions (bug 1676630)
testing/mozbase/mozproxy/mozproxy/backends/mitm/scripts/alternate-server-replay.py
--- a/testing/mozbase/mozproxy/mozproxy/backends/mitm/scripts/alternate-server-replay.py
+++ b/testing/mozbase/mozproxy/mozproxy/backends/mitm/scripts/alternate-server-replay.py
@@ -242,34 +242,23 @@ class AlternateServerPlayback:
             self._done = True
 
     def request(self, f):
         if self.flowmap:
             try:
                 rflow = self.next_flow(f)
                 if rflow:
                     response = rflow.response.copy()
-                    if response.get_content():
-                        response.is_replay = True
-                        # Refresh server replay responses by adjusting date, expires and
-                        # last-modified headers, as well as adjusting cookie expiration.
-                        response.refresh()
+                    response.is_replay = True
+                    # Refresh server replay responses by adjusting date, expires and
+                    # last-modified headers, as well as adjusting cookie expiration.
+                    response.refresh()
 
-                        f.response = response
-                        self._replayed += 1
-                    else:
-                        f.response = http.HTTPResponse.make(
-                            404, b"", {"content-type": "text/plain"}
-                        )
-                        ctx.log.info(
-                            "server_playback: dropped request with no-content response {}".format(
-                                f.request.url
-                            )
-                        )
-                        self._not_replayed += 1
+                    f.response = response
+                    self._replayed += 1
                 else:
                     # returns 404 rather than dropping the whole HTTP/2 connection
                     ctx.log.warn(
                         "server_playback: killed non-replay request {}".format(
                             f.request.url
                         )
                     )
                     f.response = http.HTTPResponse.make(