author | shindli <shindli@mozilla.com> |
Thu, 12 Apr 2018 02:51:14 +0300 | |
changeset 412858 | 88f297d206a65910871de724e9c8bb462f04d792 |
parent 412857 | 1a9a362b9288cb36b4bf3f3b04550e9586474617 |
child 412859 | 01937a864b69500fa360424f1214f00b59d2358c |
child 412861 | 99b6961d14a25843b84aab592a7f0c0a7d86e45f |
child 412908 | d2b067678e7272e826a5d75b1ccd525b554b59ee |
push id | 33821 |
push user | shindli@mozilla.com |
push date | Wed, 11 Apr 2018 23:51:29 +0000 |
treeherder | mozilla-central@88f297d206a6 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | backout |
bugs | 1423261, 1453252 |
milestone | 61.0a1 |
backs out | f45d6ae3fdb194a07ef5eba9f9a760f28f564b64 |
first release with | nightly linux32
88f297d206a6
/
61.0a1
/
20180412001050
/
files
nightly linux64
88f297d206a6
/
61.0a1
/
20180412001050
/
files
nightly mac
88f297d206a6
/
61.0a1
/
20180412001050
/
files
nightly win32
88f297d206a6
/
61.0a1
/
20180412001050
/
files
nightly win64
88f297d206a6
/
61.0a1
/
20180412001050
/
files
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
releases | nightly linux32
61.0a1
/
20180412001050
/
pushlog to previous
nightly linux64
61.0a1
/
20180412001050
/
pushlog to previous
nightly mac
61.0a1
/
20180412001050
/
pushlog to previous
nightly win32
61.0a1
/
20180412001050
/
pushlog to previous
nightly win64
61.0a1
/
20180412001050
/
pushlog to previous
|
--- a/dom/ipc/ContentParent.cpp +++ b/dom/ipc/ContentParent.cpp @@ -3182,36 +3182,27 @@ ContentParent::KillHard(const char* aRea NS_LITERAL_CSTRING("ipc_channel_error"), reason); Telemetry::Accumulate(Telemetry::SUBPROCESS_KILL_HARD, reason, 1); RefPtr<ContentParent> self = this; std::function<void(bool)> callback = [self](bool aResult) { self->OnGenerateMinidumpComplete(aResult); - MessageChannel* channel = self->GetIPCChannel(); - if (channel) { - channel->Close(); - } }; // Generate the report and insert into the queue for submittal. mCrashReporter->GenerateMinidumpAndPair(Process(), nullptr, NS_LITERAL_CSTRING("browser"), Move(callback), true); return; } OnGenerateMinidumpComplete(false); - - MessageChannel* channel = GetIPCChannel(); - if (channel) { - channel->Close(); - } } void ContentParent::OnGenerateMinidumpComplete(bool aDumpResult) { if (mCrashReporter && aDumpResult) { // CrashReporterHost::GenerateMinidumpAndPair() is successful. mCreatedPairedMinidumps = mCrashReporter->FinalizeCrashReport();