Bug 1379793 - Only allow pre header as title. r=jwu
authorNevin Chen <cnevinchen@gmail.com>
Mon, 18 Sep 2017 18:08:49 +0800
changeset 381605 88ee1e36eb17e5483d864c16d2060969726b011a
parent 381604 25a9fbed058272223cbf45e2240c5e12474175b5
child 381606 5d3fe46e02cc3e9c8b947bb330c89b369c95e3a9
push id32535
push userkwierso@gmail.com
push dateTue, 19 Sep 2017 21:06:08 +0000
treeherdermozilla-central@c0d1f9eb2a40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjwu
bugs1379793
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1379793 - Only allow pre header as title. r=jwu MozReview-Commit-ID: 294jTWWyL69
mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java
--- a/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java
+++ b/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java
@@ -103,24 +103,16 @@ public class GeckoPreferenceFragment ext
      * This method sets the title that you see on non-multi-pane devices.
      */
     private String getTitle() {
         final int res = getResource();
         if (res == R.xml.preferences) {
             return getString(R.string.settings_title);
         }
 
-        if (res == R.xml.preferences_general) {
-            return getString(R.string.pref_category_general);
-        }
-
-        if (res == R.xml.preferences_home) {
-            return getString((R.string.pref_category_home));
-        }
-
         // We can launch this category from the Data Reporting notification.
         if (res == R.xml.preferences_privacy) {
             return getString(R.string.pref_category_privacy_short);
         }
 
         // We can launch this category from the the magnifying glass in the quick search bar.
         if (res == R.xml.preferences_search) {
             return getString(R.string.pref_category_search);