Bug 1593066 - Remove XBL <children> support in arrowscrollbox _getScrollableElements r=bgrins
authorChristoph Walcher <christoph-wa@gmx.de>
Mon, 04 Nov 2019 14:32:12 +0000
changeset 500379 88d9d6ff69d74941cdb3347bf8900c0f45b9fa3c
parent 500378 dce0e0b88e8a36ed6580ef51d3aa1cfbbea36db9
child 500380 de9d244524e4be16623f91e9738517baaef75ad7
push id36763
push userrmaries@mozilla.com
push dateMon, 04 Nov 2019 21:44:06 +0000
treeherdermozilla-central@75a7a3400888 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1593066
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1593066 - Remove XBL <children> support in arrowscrollbox _getScrollableElements r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D51537
toolkit/content/widgets/arrowscrollbox.js
--- a/toolkit/content/widgets/arrowscrollbox.js
+++ b/toolkit/content/widgets/arrowscrollbox.js
@@ -354,21 +354,16 @@
       this.ensureElementIsVisible(targetElement, aInstant);
     }
 
     _getScrollableElements() {
       let nodes = this.children;
       if (nodes.length == 1) {
         let node = nodes[0];
         if (
-          node.localName == "children" &&
-          node.namespaceURI == "http://www.mozilla.org/xbl"
-        ) {
-          nodes = document.getBindingParent(this).children;
-        } else if (
           node.localName == "slot" &&
           node.namespaceURI == "http://www.w3.org/1999/xhtml"
         ) {
           nodes = node.getRootNode().host.children;
         }
       }
       return Array.prototype.filter.call(nodes, this._canScrollToElement, this);
     }