Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r=poiru
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 18:03:39 -0700
changeset 288677 8882a15789b0eb9d5ff5bd1728fd38b2c9cc4d6b
parent 288676 c19d7ab6f3bac7d10cef454fc480893004d3fe75
child 288678 676fc640c532865c16cda8102b9c3ddc2e8357fa
push id30087
push usercbook@mozilla.com
push dateTue, 15 Mar 2016 09:43:43 +0000
treeherdermozilla-central@5e14887312d4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspoiru
bugs1256509
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r=poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. MozReview-Commit-ID: 2MIqvI3qCsZ
layout/forms/moz.build
--- a/layout/forms/moz.build
+++ b/layout/forms/moz.build
@@ -53,8 +53,14 @@ LOCAL_INCLUDES += [
     '/dom/html',
 ]
 
 if CONFIG['ENABLE_INTL_API']:
     # nsNumberControlFrame.cpp requires ICUUtils.h which in turn requires
     # i18n/unum.h
     CXXFLAGS += CONFIG['MOZ_ICU_CFLAGS']
     LOCAL_INCLUDES += CONFIG['MOZ_ICU_INCLUDES']
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary hack to support building with VS2015.
+    # 'noexcept' used with no exception handling mode specified;
+    # termination on exception is not guaranteed. Specify /EHsc
+    CXXFLAGS += ['-wd4577']