author | Brian R. Bondy <netzen@gmail.com> |
Mon, 06 Apr 2015 12:03:19 -0400 (2015-04-06) | |
changeset 237699 | 883e17fc475fb4589524876f7630a0345780e38e |
parent 237698 | 1aaa76c1c3ad6466aeeb9b56bc7d20c6a1b05167 |
child 237721 | e50ea7bee5600ebddf7316c9ae73f941992beb93 |
push id | 28546 |
push user | netzen@gmail.com |
push date | Mon, 06 Apr 2015 16:08:39 +0000 (2015-04-06) |
treeherder | mozilla-central@883e17fc475f [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | rstrong, Callek |
bugs | 973933 |
milestone | 40.0a1 |
first release with | nightly mac
883e17fc475f
/
40.0a1
/
20150406120851
/
files
nightly win32
883e17fc475f
/
40.0a1
/
20150406145430
/
files
nightly win64
883e17fc475f
/
40.0a1
/
20150406151932
/
files
nightly linux32
nightly linux64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
releases | nightly mac
40.0a1
/
20150406120851
/
pushlog to previous
nightly win32
40.0a1
/
20150406145430
/
pushlog to previous
nightly win64
40.0a1
/
20150406151932
/
pushlog to previous
|
--- a/modules/libmar/tool/mar.c +++ b/modules/libmar/tool/mar.c @@ -112,33 +112,33 @@ static int mar_test(const char *path) { return 0; } int main(int argc, char **argv) { char *NSSConfigDir = NULL; const char *certNames[MAX_SIGNATURES]; char *MARChannelID = MAR_CHANNEL_ID; char *productVersion = MOZ_APP_VERSION; - uint32_t i, k; + uint32_t k; int rv = -1; uint32_t certCount = 0; int32_t sigIndex = -1; #if !defined(NO_SIGN_VERIFY) uint32_t fileSizes[MAX_SIGNATURES]; - uint8_t* certBuffers[MAX_SIGNATURES]; + const uint8_t* certBuffers[MAX_SIGNATURES]; char* DERFilePaths[MAX_SIGNATURES]; #if (!defined(XP_WIN) && !defined(XP_MACOSX)) || defined(MAR_NSS) CERTCertificate* certs[MAX_SIGNATURES]; #endif #endif - memset(certNames, 0, sizeof(certNames)); + memset((void*)certNames, 0, sizeof(certNames)); #if defined(XP_WIN) && !defined(MAR_NSS) && !defined(NO_SIGN_VERIFY) - memset(certBuffers, 0, sizeof(certBuffers)); + memset((void*)certBuffers, 0, sizeof(certBuffers)); #endif #if !defined(NO_SIGN_VERIFY) && ((!defined(MAR_NSS) && defined(XP_WIN)) || \ defined(XP_MACOSX)) memset(DERFilePaths, 0, sizeof(DERFilePaths)); memset(fileSizes, 0, sizeof(fileSizes)); #endif if (argc > 1 && 0 == strcmp(argv[1], "--version")) { @@ -371,17 +371,17 @@ int main(int argc, char **argv) { mar_close(mar); } else { fprintf(stderr, "ERROR: Could not open MAR file.\n"); rv = -1; } } for (k = 0; k < certCount; ++k) { #if (defined(XP_WIN) || defined(XP_MACOSX)) && !defined(MAR_NSS) - free(certBuffers[k]); + free((void*)certBuffers[k]); #else /* certBuffers[k] is owned by certs[k] so don't free it */ CERT_DestroyCertificate(certs[k]); #endif } if (rv) { /* Determine if the source MAR file has the new fields for signing */ int hasSignatureBlock;