Bug 1527515 - Enable building BinAST on win32 and android nightlies. r=Yoric
authorTooru Fujisawa <arai_a@mac.com>
Wed, 13 Feb 2019 08:42:47 +0000
changeset 458860 8826dd4a075a
parent 458859 23fa2fb048b9
child 458861 0dca936d2e9e
push id35551
push usershindli@mozilla.com
push dateWed, 13 Feb 2019 21:34:09 +0000
treeherdermozilla-central@08f794a4928e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersYoric
bugs1527515
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1527515 - Enable building BinAST on win32 and android nightlies. r=Yoric Differential Revision: https://phabricator.services.mozilla.com/D19608
js/moz.configure
testing/web-platform/mozilla/meta/binast/domain-restrict-included.https.html.ini
testing/web-platform/mozilla/meta/binast/large.https.html.ini
testing/web-platform/mozilla/meta/binast/small.https.html.ini
--- a/js/moz.configure
+++ b/js/moz.configure
@@ -483,21 +483,19 @@ def enable_pipeline_operator(value):
 set_config('ENABLE_PIPELINE_OPERATOR', enable_pipeline_operator)
 set_define('ENABLE_PIPELINE_OPERATOR', enable_pipeline_operator)
 
 
 
 # Experimental support for BinAST
 # ==============================================================
 
-@depends(target, milestone)
-def enable_build_binast(target, milestone):
-    # For reasons unknown at this time, BinAST causes timeouts on win32
-    # and failures on Android.
-    if milestone.is_nightly and not (target.kernel == 'WINNT' and target.cpu == 'x86') and not (target.os == 'Android'):
+@depends(milestone)
+def enable_build_binast(milestone):
+    if milestone.is_nightly:
         return True
 
 set_define('JS_BUILD_BINAST', enable_build_binast)
 set_config('JS_BUILD_BINAST', enable_build_binast)
 
 
 # Experimental support for wasm code generation with Cranelift
 # ==============================================================
--- a/testing/web-platform/mozilla/meta/binast/domain-restrict-included.https.html.ini
+++ b/testing/web-platform/mozilla/meta/binast/domain-restrict-included.https.html.ini
@@ -1,7 +1,7 @@
 [domain-restrict-included.https.html]
   prefs: [dom.script_loader.binast_encoding.domain.restrict:true,
           dom.script_loader.binast_encoding.domain.restrict.list:web-platform.test]
   [Check we can load BinAST if the host is included in the list]
     expected:
-      if release_or_beta or (os == "android") or ((os == "win") and (processor == "x86")): FAIL
+      if release_or_beta: FAIL
 
--- a/testing/web-platform/mozilla/meta/binast/large.https.html.ini
+++ b/testing/web-platform/mozilla/meta/binast/large.https.html.ini
@@ -1,6 +1,6 @@
 [large.https.html]
   prefs: [dom.script_loader.binast_encoding.domain.restrict:false]
   [Check we can load BinAST over HTTPS]
     expected:
-      if release_or_beta or (os == "android") or ((os == "win") and (processor == "x86")): FAIL
+      if release_or_beta: FAIL
 
--- a/testing/web-platform/mozilla/meta/binast/small.https.html.ini
+++ b/testing/web-platform/mozilla/meta/binast/small.https.html.ini
@@ -1,6 +1,6 @@
 [small.https.html]
   prefs: [dom.script_loader.binast_encoding.domain.restrict:false]
   [Check we can load BinAST over HTTPS]
     expected:
-      if release_or_beta or (os == "android") or ((os == "win") and (processor == "x86")): FAIL
+      if release_or_beta: FAIL