Bug 1587780 - Unify close/remove button between Debugger and NetMonitor r=Honza
authorDavid Walsh <dwalsh@mozilla.com>
Fri, 11 Oct 2019 13:00:57 +0000
changeset 497274 8813a475c23796f0e83305c1c71e97eb4cb2c88c
parent 497273 7fe7debdb0f60b80757434a3e12f2d7d59ea041e
child 497275 c9ea9966d4cdc4007eb3c4a023ad87fa891eda33
push id36681
push usercbrindusan@mozilla.com
push dateFri, 11 Oct 2019 21:50:12 +0000
treeherdermozilla-central@c5e6477c3a24 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1587780
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1587780 - Unify close/remove button between Debugger and NetMonitor r=Honza Differential Revision: https://phabricator.services.mozilla.com/D48875
devtools/client/netmonitor/src/assets/styles/RequestBlockingPanel.css
--- a/devtools/client/netmonitor/src/assets/styles/RequestBlockingPanel.css
+++ b/devtools/client/netmonitor/src/assets/styles/RequestBlockingPanel.css
@@ -64,20 +64,40 @@
 
 .network-monitor .request-blocking-enable-form label,
 .network-monitor .request-blocking-list label {
   margin-top: 2px;
 }
 
 .network-monitor .request-blocking-list button {
   visibility: hidden;
+  width: 16px;
+  height: 16px;
+  border-radius: 2px;
+  padding: 1px;
+  margin-top: 3px;
 }
 
-.network-monitor .request-blocking-list button::before {
+.network-monitor .request-blocking-list .devtools-button:empty::before {
+  width: 12px;
+  height: 12px;
+  margin: 0;
   background-image: url("chrome://devtools/skin/images/close.svg");
+  background-size: 12px 12px;
+  background-position: 0 -1px;
+}
+
+.network-monitor .request-blocking-list .devtools-button:empty:hover,
+.network-monitor .request-blocking-list .devtools-button:empty:focus {
+  background-color: var(--theme-selection-background) !important;
+}
+
+.network-monitor .request-blocking-list button:hover::before,
+.network-monitor .request-blocking-list button:focus::before {
+  fill: #fff;
 }
 
 .network-monitor .request-blocking-list li:hover button,
 .network-monitor .request-blocking-list li:focus-within button {
   visibility: visible;
 }
 
 /* Addition form */