Bug 1401945 - Do not use the WebRenderUserData after it's removed. r=jrmuizel,kats
authorEthan Lin <ethlin@mozilla.com>
Thu, 21 Sep 2017 23:15:55 +0800
changeset 382236 880571f390485329eeca41daa02d66a2ccc1e975
parent 382235 f1ae02c8d697c6ca0c1a24cdadcca304b8a30638
child 382237 a69946757ded48de0b47d7b11b6268a636255502
push id32551
push userkwierso@gmail.com
push dateThu, 21 Sep 2017 23:29:53 +0000
treeherdermozilla-central@d6d6fd889f7b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel, kats
bugs1401945
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1401945 - Do not use the WebRenderUserData after it's removed. r=jrmuizel,kats MozReview-Commit-ID: AL8tO0ZxVkF
gfx/layers/wr/WebRenderLayerManager.h
--- a/gfx/layers/wr/WebRenderLayerManager.h
+++ b/gfx/layers/wr/WebRenderLayerManager.h
@@ -277,17 +277,19 @@ private:
         MOZ_ASSERT(userDataTable->Count());
 
         userDataTable->Remove(data->GetDisplayItemKey());
 
         if (!userDataTable->Count()) {
           frame->RemoveProperty(nsIFrame::WebRenderUserDataProperty());
         }
         iter.Remove();
+        continue;
       }
+
       data->SetUsed(false);
     }
   }
 
 private:
   nsIWidget* MOZ_NON_OWNING_REF mWidget;
   nsTArray<wr::ImageKey> mImageKeysToDelete;
   // TODO - This is needed because we have some code that creates image keys