Bug 982640 - Port GTK2 to GTK3 - transparent widgets, r=karlt
authorMartin Stransky <stransky@redhat.com>
Wed, 26 Mar 2014 10:16:38 -0700
changeset 175536 86d42bf1b19ba3cfd0f2bcb942e328e25564e1bb
parent 175535 e4a0840842606aa0e295b41fae0ff3d63e05c7b9
child 175537 636fa31743682646c76d8d93fcef5d900e3d2ee5
push id26492
push userryanvm@gmail.com
push dateThu, 27 Mar 2014 00:57:51 +0000
treeherdermozilla-central@441f5fd256e2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskarlt
bugs982640
milestone31.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 982640 - Port GTK2 to GTK3 - transparent widgets, r=karlt Some widgets in Gtk3 are transparent so force gecko to paint underlying widget which is usually GtkWindow.
widget/gtk/nsNativeThemeGTK.cpp
--- a/widget/gtk/nsNativeThemeGTK.cpp
+++ b/widget/gtk/nsNativeThemeGTK.cpp
@@ -1463,20 +1463,20 @@ nsNativeThemeGTK::ThemeNeedsComboboxDrop
   return false;
 }
 
 nsITheme::Transparency
 nsNativeThemeGTK::GetWidgetTransparency(nsIFrame* aFrame, uint8_t aWidgetType)
 {
   switch (aWidgetType) {
   // These widgets always draw a default background.
+#if (MOZ_WIDGET_GTK == 2)
   case NS_THEME_SCROLLBAR_TRACK_VERTICAL:
   case NS_THEME_SCROLLBAR_TRACK_HORIZONTAL:
   case NS_THEME_TOOLBAR:
-#if (MOZ_WIDGET_GTK == 2)
   case NS_THEME_MENUBAR:
 #endif
   case NS_THEME_MENUPOPUP:
   case NS_THEME_WINDOW:
   case NS_THEME_DIALOG:
   // Tooltips use gtk_paint_flat_box().
   case NS_THEME_TOOLTIP:
     return eOpaque;