Bug 1228628: Move all eslintignore rules to the top-level of the tree. r=mconley
authorDave Townsend <dtownsend@oxymoronical.com>
Fri, 27 Nov 2015 09:39:59 -0800
changeset 274498 85bf0c3e44fd07810cfcc948cd55ef0b300ea5f8
parent 274497 19876a153a009b457900c82f27efbc398ad19413
child 274499 a39eb15b6fd41717dc962d1f66cec6d2220e26c8
push id29733
push usercbook@mozilla.com
push dateMon, 30 Nov 2015 12:16:19 +0000
treeherdermozilla-central@2d385f1302a2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1228628
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1228628: Move all eslintignore rules to the top-level of the tree. r=mconley
.eslintignore
devtools/.eslintignore
mobile/android/.eslintignore
python/mach_commands.py
new file mode 100644
--- /dev/null
+++ b/.eslintignore
@@ -0,0 +1,157 @@
+# Always ignore node_modules.
+**/node_modules/**/*.*
+
+# Exclude expected objdirs.
+obj*/**
+
+# We ignore all these directories by default, until we get them enabled.
+# If you are enabling a directory, please add directory specific exclusions
+# below.
+accessible/**
+addon-sdk/**
+b2g/**
+build/**
+caps/**
+chrome/**
+config/**
+db/**
+docshell/**
+dom/**
+editor/**
+embedding/**
+extensions/**
+gfx/**
+gradle/**
+hal/**
+image/**
+intl/**
+ipc/**
+js/**
+layout/**
+media/**
+memory/**
+mfbt/**
+modules/**
+mozglue/**
+netwerk/**
+nsprpub/**
+other-licenses/**
+parser/**
+probes/**
+python/**
+rdf/**
+security/**
+services/**
+startupcache/**
+storage/**
+testing/**
+toolkit/**
+tools/**
+uriloader/**
+view/**
+webapprt/**
+widget/**
+xpcom/**
+xpfe/**
+xulrunner/**
+
+# browser/ exclusions
+browser/app/**
+browser/base/**
+browser/branding/**
+browser/components/**
+browser/config/**
+browser/docs/**
+browser/experiments/**
+browser/extensions/pdfjs/**
+browser/extensions/shumway/**
+browser/fuel/**
+browser/installer/**
+browser/locales/**
+browser/modules/**
+browser/themes/**
+
+# Loop specific exclusions
+
+# This file currently uses a non-standard (and not on a standards track)
+# if statement within catch.
+browser/extensions/loop/content/modules/MozLoopWorker.js
+# This file currently uses es7 features eslint issue:
+# https://github.com/eslint/espree/issues/125
+browser/extensions/loop/content/modules/MozLoopAPI.jsm
+# Need to fix the configuration for this.
+browser/extensions/loop/bootstrap.js
+# Need to drop the preprocessing (bug 1212428)
+browser/extensions/loop/content/preferences/prefs.js
+# Libs we don't need to check
+browser/extensions/loop/content/panels/vendor
+browser/extensions/loop/content/shared/vendor
+browser/extensions/loop/standalone/content/libs
+# Libs we don't need to check
+browser/extensions/loop/test/shared/vendor
+# Coverage files
+browser/extensions/loop/test/coverage
+# These are generated react files that we don't need to check
+browser/extensions/loop/content/panels/js/conversation.js
+browser/extensions/loop/content/panels/js/conversationViews.js
+browser/extensions/loop/content/panels/js/panel.js
+browser/extensions/loop/content/panels/js/roomViews.js
+browser/extensions/loop/content/panels/js/feedbackViews.js
+browser/extensions/loop/content/shared/js/textChatView.js
+browser/extensions/loop/content/shared/js/linkifiedTextView.js
+browser/extensions/loop/content/shared/js/views.js
+browser/extensions/loop/standalone/content/js/standaloneRoomViews.js
+browser/extensions/loop/standalone/content/js/webapp.js
+browser/extensions/loop/ui/ui-showcase.js
+# Don't need to check the built tree
+browser/extensions/loop/standalone/dist
+
+# devtools/ exclusions
+# Ignore d3
+devtools/client/shared/d3.js
+devtools/client/webaudioeditor/lib/dagre-d3.js
+
+# Ignore codemirror
+devtools/client/sourceeditor/codemirror/*.js
+devtools/client/sourceeditor/codemirror/**/*.js
+
+# Ignore jquery test libs
+devtools/client/markupview/test/lib_*
+
+# Ignore pre-processed files
+devtools/client/framework/toolbox-process-window.js
+devtools/client/performance/system.js
+devtools/client/webide/webide-prefs.js
+
+# Ignore various libs
+devtools/shared/jsbeautify/*
+devtools/shared/acorn/*
+devtools/shared/tern/*
+devtools/shared/pretty-fast/*
+devtools/shared/sourcemap/*
+
+# mobile/android/ exclusions
+mobile/android/chrome/content
+mobile/android/tests/
+
+# Uses `#filter substitution`
+mobile/android/b2gdroid/app/b2gdroid.js
+mobile/android/app/mobile.js
+mobile/android/chrome/content/healthreport-prefs.js
+
+# Uses `#expand`
+mobile/android/chrome/content/about.js
+
+# Not much JS to lint and non-standard at that
+mobile/android/installer/
+mobile/android/locales/
+
+# Pretty sure we're disabling this one anyway
+mobile/android/modules/ContactService.jsm
+
+# es7 proposed: array comprehensions
+#   https://github.com/eslint/espree/issues/125
+mobile/android/modules/WebappManager.jsm
+
+# Non-standard `(catch ex if ...)`
+mobile/android/components/Snippets.js
deleted file mode 100644
--- a/devtools/.eslintignore
+++ /dev/null
@@ -1,22 +0,0 @@
-# Ignore d3
-client/shared/d3.js
-client/webaudioeditor/lib/dagre-d3.js
-
-# Ignore codemirror
-client/sourceeditor/codemirror/*.js
-client/sourceeditor/codemirror/**/*.js
-
-# Ignore jquery test libs
-client/markupview/test/lib_*
-
-# Ignore pre-processed files
-client/framework/toolbox-process-window.js
-client/performance/system.js
-client/webide/webide-prefs.js
-
-# Ignore various libs
-shared/jsbeautify/*
-shared/acorn/*
-shared/tern/*
-shared/pretty-fast/*
-shared/sourcemap/*
deleted file mode 100644
--- a/mobile/android/.eslintignore
+++ /dev/null
@@ -1,23 +0,0 @@
-chrome/content
-tests/
-
-# Uses `#filter substitution`
-app/mobile.js
-chrome/content/healthreport-prefs.js
-
-# Uses `#expand`
-chrome/content/about.js
-
-# Not much JS to lint and non-standard at that
-installer/
-locales/
-
-# Pretty sure we're disabling this one anyway
-modules/ContactService.jsm
-
-# es7 proposed: array comprehensions
-#   https://github.com/eslint/espree/issues/125
-modules/WebappManager.jsm
-
-# Non-standard `(catch ex if ...)`
-components/Snippets.js
--- a/python/mach_commands.py
+++ b/python/mach_commands.py
@@ -207,21 +207,20 @@ class MachCommands(MachCommandBase):
         # we just print the active path.
 
         self.log(logging.INFO, 'eslint', {'binary': binary, 'path': path},
             'Running {binary} in {path}')
 
         cmd_args = [binary,
             '--ext', ext,  # This keeps ext as a single argument.
         ] + args
-        # Path must come after arguments.  Path is '.' due to cwd below.
-        cmd_args += ['.']
+        # Path must come after arguments.
+        cmd_args += [path]
 
         return self.run_process(cmd_args,
-            cwd=path,
             pass_thru=True,  # Allow user to run eslint interactively.
             ensure_exit_code=False,  # Don't throw on non-zero exit code.
         )
     def eslint_setup(self, update_only=False):
         """Ensure eslint is optimally configured.
 
         This command will inspect your eslint configuration and
         guide you through an interactive wizard helping you configure