Bug 1535442 - Part 7: Allow empty |candidate| and check that |usernameFragment| is present. r=jib
☠☠ backed out by cebb5fa563f9 ☠ ☠
authorByron Campen [:bwc] <docfaraday@gmail.com>
Tue, 26 Mar 2019 17:42:46 +0000
changeset 466213 8342491a4e91861a5e1f3642c29e512600c6a013
parent 466212 53556fae6a9bd9f651e68c37c8b821fb79c363ef
child 466214 96249192254a3d086cd45784a52505888e176d7a
push id35762
push usercsabou@mozilla.com
push dateWed, 27 Mar 2019 04:44:00 +0000
treeherdermozilla-central@bc572aee49b6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1535442
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1535442 - Part 7: Allow empty |candidate| and check that |usernameFragment| is present. r=jib Differential Revision: https://phabricator.services.mozilla.com/D24281
dom/media/tests/mochitest/pc.js
--- a/dom/media/tests/mochitest/pc.js
+++ b/dom/media/tests/mochitest/pc.js
@@ -1426,18 +1426,18 @@ PeerConnectionWrapper.prototype = {
         info(this.label + ": received end of trickle ICE event");
         ok(this._pc.iceGatheringState === 'complete',
            "ICE gathering state has reached complete");
         resolveEndOfTrickle(this.label);
         return;
       }
 
       info(this.label + ": iceCandidate = " + JSON.stringify(anEvent.candidate));
-      ok(anEvent.candidate.candidate.length > 0, "ICE candidate contains candidate");
       ok(anEvent.candidate.sdpMid.length > 0, "SDP mid not empty");
+      ok(anEvent.candidate.usernameFragment.length > 0, "usernameFragment not empty");
 
       // only check the m-section for the updated default addr that corresponds
       // with this candidate.
       var mSections = this.localDescription.sdp.split("\r\nm=");
       sdputils.checkSdpCLineNotDefault(
         mSections[anEvent.candidate.sdpMLineIndex+1], this.label
       );