Bug 1466727 part 1. Mark nsITreeColumn builtinclass. r=mossop
authorBoris Zbarsky <bzbarsky@mit.edu>
Tue, 05 Jun 2018 23:01:36 -0400
changeset 421559 824b74c6269d69430a89301af2a638da0d0cd69c
parent 421530 633a10eff02a2ada758db8459dc9927bbce31df5
child 421560 96c6c5a075a4d065b5117f23ed4bc1fa5c70a683
push id34098
push usernbeleuzu@mozilla.com
push dateWed, 06 Jun 2018 17:00:32 +0000
treeherdermozilla-central@04cc917f68c5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmossop
bugs1466727
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466727 part 1. Mark nsITreeColumn builtinclass. r=mossop The only JS implementation seems to be in a test, and we can stop doing that.
browser/components/sessionstore/test/browser_aboutSessionRestore.js
layout/xul/tree/nsITreeColumns.idl
--- a/browser/components/sessionstore/test/browser_aboutSessionRestore.js
+++ b/browser/components/sessionstore/test/browser_aboutSessionRestore.js
@@ -24,19 +24,21 @@ add_task(async function() {
   await promiseBrowserLoaded(browser);
 
   // Fake a post-crash tab.
   ss.setTabState(tab, JSON.stringify(TAB_STATE));
   await promiseTabRestored(tab);
 
   ok(gBrowser.tabs.length > 1, "we have more than one tab");
 
-  let view = browser.contentDocument.getElementById("tabList").view;
+  let tree = browser.contentDocument.getElementById("tabList");
+  let view = tree.view;
   ok(view.isContainer(0), "first entry is the window");
-  is(view.getCellProperties(1, { id: "title" }), "icon",
+  let titleColumn = tree.columns.title;
+  is(view.getCellProperties(1, titleColumn), "icon",
     "second entry is the tab and has a favicon");
 
   browser.messageManager.loadFrameScript(FRAME_SCRIPT, true);
 
   // Wait until the new window was restored.
   let win = await waitForNewWindow();
   await BrowserTestUtils.closeWindow(win);
 
--- a/layout/xul/tree/nsITreeColumns.idl
+++ b/layout/xul/tree/nsITreeColumns.idl
@@ -2,17 +2,17 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "nsISupports.idl"
 
 webidl Element;
 webidl TreeColumns;
 
-[scriptable, uuid(ae835ecf-6b32-4660-9b43-8a270df56e02)]
+[scriptable, builtinclass, uuid(ae835ecf-6b32-4660-9b43-8a270df56e02)]
 interface nsITreeColumn : nsISupports
 {
   readonly attribute Element element;
 
   readonly attribute TreeColumns columns;
 
   readonly attribute long x;
   readonly attribute long width;