Bug 1462336 [wpt PR 11042] - Revert "[ForeignObject] Paint foreign objects during the foreground phase of normal-flow", a=testonly
authorFinnur Thorarinsson <finnur@chromium.org>
Sat, 19 May 2018 20:46:13 +0000
changeset 419093 822a0fb72ead022039b2c6d8349666300e281bd6
parent 419092 baf5c4e871aa5c67d4fbc447bf4583afd3d2018c
child 419094 d137a17ed0346ef582f5bb18dae7dc02f116ff40
push id34026
push userapavel@mozilla.com
push dateMon, 21 May 2018 09:47:33 +0000
treeherdermozilla-central@dc1868d255be [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1462336, 11042, 842668, 1060333, 559401, 1064150, 559496
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1462336 [wpt PR 11042] - Revert "[ForeignObject] Paint foreign objects during the foreground phase of normal-flow", a=testonly Automatic update from web-platform-testsRevert "[ForeignObject] Paint foreign objects during the foreground phase of normal-flow" This reverts commit 02a5799e0e02d7e7274d78833f897c81ae2cc434. Reason for revert: Consistent failure of zoom-foreignObject.svg test on Windows 7. See list: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/ Original change's description: > [ForeignObject] Paint foreign objects during the foreground phase of normal-flow > descendants. > > When <foreignObject> was made a stacking context, it also had the side-effect of > painting it at the same time as positioned elements. This is a change to painting > order and caused a regression. Instead, implement a new mechanism by which a > "replaced normal-flow stacking" element paints during the foreground phase > of the LayoutObject paint tree walk. > > This is used for now just for <foreignObject>, but may be applied to other > replaced elements such as iframes or embedded objects in the future. > > Bug:842668 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I450944986abfb6610084444abf2724e7406145cf > Reviewed-on: https://chromium-review.googlesource.com/1060333 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559401} TBR=trchen@chromium.org,pdr@chromium.org,chrishtr@chromium.org Change-Id: I6742e134dae28a31bcb80fd13eccbc83d03ef332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1064150 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#559496} -- wpt-commits: 9d9ef5545b98e9890bd7a4dccf12c161911ab98a wpt-pr: 11042
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/svg/extensibility/foreignObject/foreign-object-paints-before-rect-expected.html
testing/web-platform/tests/svg/extensibility/foreignObject/foreign-object-paints-before-rect.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -183630,28 +183630,16 @@
       [
        "/shadow-dom/untriaged/styles/not-apply-in-shadow-root-001-ref.html",
        "=="
       ]
      ],
      {}
     ]
    ],
-   "svg/extensibility/foreignObject/foreign-object-paints-before-rect.html": [
-    [
-     "/svg/extensibility/foreignObject/foreign-object-paints-before-rect.html",
-     [
-      [
-       "/svg/extensibility/foreignObject/foreign-object-paints-before-rect-expected.html",
-       "=="
-      ]
-     ],
-     {}
-    ]
-   ],
    "svg/extensibility/foreignObject/stacking-context.html": [
     [
      "/svg/extensibility/foreignObject/stacking-context.html",
      [
       [
        "/svg/extensibility/foreignObject/stacking-context-ref.html",
        "=="
       ]
@@ -297588,21 +297576,16 @@
      {}
     ]
    ],
    "svg/README.md": [
     [
      {}
     ]
    ],
-   "svg/extensibility/foreignObject/foreign-object-paints-before-rect-expected.html": [
-    [
-     {}
-    ]
-   ],
    "svg/extensibility/foreignObject/stacking-context-ref.html": [
     [
      {}
     ]
    ],
    "svg/foreignobject/position-svg-root-in-foreign-object-ref.html": [
     [
      {}
@@ -608429,24 +608412,16 @@
   "svg/README.md": [
    "ce9e3471676d5a50b91f6b274d648b481e509223",
    "support"
   ],
   "svg/extensibility/foreignObject/containing-block.html": [
    "6ed9e162526cbf37fb07c1cb7abbe79d987601c8",
    "testharness"
   ],
-  "svg/extensibility/foreignObject/foreign-object-paints-before-rect-expected.html": [
-   "18e188a6279e64cbabdd4bb638b06d4a5b22fca8",
-   "support"
-  ],
-  "svg/extensibility/foreignObject/foreign-object-paints-before-rect.html": [
-   "f626d744f7bd101cf31d85e59747e8470fa91398",
-   "reftest"
-  ],
   "svg/extensibility/foreignObject/properties.svg": [
    "974affbb2c135c9aaa7a3f27687157b5e1250a9f",
    "testharness"
   ],
   "svg/extensibility/foreignObject/stacking-context-ref.html": [
    "6ea850b74b6a03554305ed95df45079bdbcb15dd",
    "support"
   ],
deleted file mode 100644
--- a/testing/web-platform/tests/svg/extensibility/foreignObject/foreign-object-paints-before-rect-expected.html
+++ /dev/null
@@ -1,12 +0,0 @@
-<!doctype HTML>
-<!doctype HTML>
-<style>
-* {
-  margin: 0
-}
-</style>
-<svg style="width: 500px; height: 500px">
-  <rect x="0" y="0" width="100%" height="100%" style="fill: blue"/>
-  <rect x="0" y="0" width="50%" height="50%"/>
-</svg>
-
deleted file mode 100644
--- a/testing/web-platform/tests/svg/extensibility/foreignObject/foreign-object-paints-before-rect.html
+++ /dev/null
@@ -1,16 +0,0 @@
-<!doctype HTML>
-<link rel="match" href="foreign-object-paints-before-rect-expected.html">
-<link rel="help" href="https://svgwg.org/svg2-draft/single-page.html#embedded-ForeignObjectElement"/>
-<style>
-* {
-  margin: 0
-}
-</style>
-<!-- Test that the <foreignObject> root element paints in element order
-within the SVG, but content within it is atomic. -->
-<svg style="width: 500px; height: 500px">
-  <foreignObject width="100%" height="100%">
-    <div style="width: 500px; height: 500px; background: blue"></div>
-  </foreignObject>
-  <rect x="0" y="0" width="50%" height="50%"/>
-</svg>