author | Ehsan Akhgari <ehsan@mozilla.com> |
Thu, 29 Nov 2018 10:46:08 -0500 | |
changeset 449284 | 82236b4be4c96f1830f6435164407b31e108bc02 |
parent 449283 | c259bf672187a0833845e15a65ffd4e73eaf42f5 |
child 449285 | 4f08283a2e3a13c454ab82115b7c6e191ada7bbd |
push id | 35157 |
push user | rmaries@mozilla.com |
push date | Tue, 04 Dec 2018 21:54:02 +0000 |
treeherder | mozilla-central@0a65dda20ade [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
bugs | 1510911, 1493563 |
milestone | 65.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/accessible/base/DocManager.cpp +++ b/accessible/base/DocManager.cpp @@ -298,18 +298,17 @@ NS_IMETHODIMP DocManager::OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP DocManager::OnSecurityChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, - uint32_t aOldState, uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + uint32_t aState) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } //////////////////////////////////////////////////////////////////////////////// // nsIDOMEventListener NS_IMETHODIMP
--- a/browser/base/content/browser-contentblocking.js +++ b/browser/base/content/browser-contentblocking.js @@ -712,18 +712,17 @@ var ContentBlocking = { shieldHistogramAdd(value) { if (PrivateBrowsingUtils.isWindowPrivate(window)) { return; } Services.telemetry.getHistogramById("TRACKING_PROTECTION_SHIELD").add(value); }, - onSecurityChange(oldState, state, webProgress, isSimulated, - contentBlockingLogJSON) { + onSecurityChange(state, webProgress, isSimulated) { let baseURI = this._baseURIForChannelClassifier; // Don't deal with about:, file: etc. if (!baseURI) { this.iconBox.removeAttribute("animate"); this.iconBox.removeAttribute("active"); this.iconBox.removeAttribute("hasException"); return;
--- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -4922,18 +4922,17 @@ var XULBrowserWindow = { _lastLocation: null, // This is called in multiple ways: // 1. Due to the nsIWebProgressListener.onSecurityChange notification. // 2. Called by tabbrowser.xml when updating the current browser. // 3. Called directly during this object's initializations. // aRequest will be null always in case 2 and 3, and sometimes in case 1 (for // instance, there won't be a request when STATE_BLOCKED_TRACKING_CONTENT is observed). - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON, aIsSimulated) { + onSecurityChange(aWebProgress, aRequest, aState, aIsSimulated) { // Don't need to do anything if the data we use to update the UI hasn't // changed let uri = gBrowser.currentURI; let spec = uri.spec; if (this._state == aState && this._lastLocation == spec) { // Switching to a tab of the same URL doesn't change most security // information, but tab specific permissions may be different. @@ -4950,18 +4949,17 @@ var XULBrowserWindow = { // Make sure the "https" part of the URL is striked out or not, // depending on the current mixed active content blocking state. gURLBar.formatValue(); try { uri = Services.uriFixup.createExposableURI(uri); } catch (e) {} gIdentityHandler.updateIdentity(this._state, uri); - ContentBlocking.onSecurityChange(aOldState, this._state, aWebProgress, aIsSimulated, - aContentBlockingLogJSON); + ContentBlocking.onSecurityChange(this._state, aWebProgress, aIsSimulated); }, // simulate all change notifications after switching tabs onUpdateCurrentBrowser: function XWB_onUpdateCurrentBrowser(aStateFlags, aStatus, aMessage, aTotalProgress) { if (FullZoom.updateBackgroundTabs) FullZoom.onLocationChange(gBrowser.currentURI, true); CombinedStopReload.onTabSwitch();
--- a/browser/base/content/tabbrowser.js +++ b/browser/base/content/tabbrowser.js @@ -957,23 +957,18 @@ window._gBrowser = { this._callProgressListeners(null, "onLocationChange", [webProgress, null, newBrowser.currentURI, 0, true], true, false); let securityUI = newBrowser.securityUI; if (securityUI) { // Include the true final argument to indicate that this event is // simulated (instead of being observed by the webProgressListener). - // Note: check state first to make sure the security UI object updates its - // state from the docshell correctly. - let state = securityUI.state; - let oldState = securityUI.oldState; this._callProgressListeners(null, "onSecurityChange", - [webProgress, null, oldState, state, - securityUI.contentBlockingLogJSON, true], + [webProgress, null, securityUI.state, true], true, false); } let listener = this._tabListeners.get(newTab); if (listener && listener.mStateFlags) { this._callProgressListeners(null, "onUpdateCurrentBrowser", [listener.mStateFlags, listener.mStatus, listener.mMessage, listener.mTotalProgress], @@ -1708,27 +1703,22 @@ window._gBrowser = { this._tabListeners.set(tab, listener); filter.addProgressListener(listener, Ci.nsIWebProgress.NOTIFY_ALL); // Restore the progress listener. aBrowser.webProgress.addProgressListener(filter, Ci.nsIWebProgress.NOTIFY_ALL); // Restore the securityUI state. let securityUI = aBrowser.securityUI; - // Make sure to call the state getter before the oldState getter to give - // the securityUI object a chance to sync its state with the docshell let state = securityUI ? securityUI.state : Ci.nsIWebProgressListener.STATE_IS_INSECURE; - let oldState = securityUI ? securityUI.oldState : - Ci.nsIWebProgressListener.STATE_IS_INSECURE; // Include the true final argument to indicate that this event is // simulated (instead of being observed by the webProgressListener). this._callProgressListeners(aBrowser, "onSecurityChange", - [aBrowser.webProgress, null, oldState, state, - securityUI.contentBlockingLogJSON, true], + [aBrowser.webProgress, null, state, true], true, false); if (aShouldBeRemote) { // Switching the browser to be remote will connect to a new child // process so the browser can no longer be considered to be // crashed. tab.removeAttribute("crashed"); } else { @@ -5201,20 +5191,19 @@ class TabProgressListener { return; this._callProgressListeners("onStatusChange", [aWebProgress, aRequest, aStatus, aMessage]); this.mMessage = aMessage; } - onSecurityChange(aWebProgress, aRequest, aOldState, aState, aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, aState) { this._callProgressListeners("onSecurityChange", - [aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON]); + [aWebProgress, aRequest, aState]); } onRefreshAttempted(aWebProgress, aURI, aDelay, aSameURI) { return this._callProgressListeners("onRefreshAttempted", [aWebProgress, aURI, aDelay, aSameURI]); } } TabProgressListener.prototype.QueryInterface = ChromeUtils.generateQI(
--- a/browser/base/content/test/general/browser_alltabslistener.js +++ b/browser/base/content/test/general/browser_alltabslistener.js @@ -31,18 +31,17 @@ var gFrontProgressListener = { ok(gFrontNotificationsPos < gFrontNotifications.length, "Got an expected notification for the front notifications listener"); is(state, gFrontNotifications[gFrontNotificationsPos], "Got a notification for the front notifications listener"); gFrontNotificationsPos++; }, onStatusChange(aWebProgress, aRequest, aStatus, aMessage) { }, - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, aState) { if (aRequest && aRequest.QueryInterface(Ci.nsIChannel).originalURI.spec == "about:blank") { // ignore initial about blank return; } var state = "onSecurityChange"; info("FrontProgress: " + state + " 0x" + aState.toString(16)); ok(gFrontNotificationsPos < gFrontNotifications.length, "Got an expected notification for the front notifications listener"); @@ -91,18 +90,17 @@ var gAllProgressListener = { aRequest.QueryInterface(Ci.nsIChannel).originalURI.spec == "about:blank") { // ignore initial about blank return; } var state = "onStatusChange"; ok(aBrowser == gTestBrowser, state + " notification came from the correct browser"); }, - onSecurityChange(aBrowser, aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aBrowser, aWebProgress, aRequest, aState) { if (aRequest && aRequest.QueryInterface(Ci.nsIChannel).originalURI.spec == "about:blank") { // ignore initial about blank return; } var state = "onSecurityChange"; info("AllProgress: " + state + " 0x" + aState.toString(16)); ok(aBrowser == gTestBrowser, state + " notification came from the correct browser");
--- a/browser/components/extensions/parent/ext-tabs.js +++ b/browser/components/extensions/parent/ext-tabs.js @@ -1216,18 +1216,17 @@ this.tabs = class extends ExtensionAPI { } if (pageSettings.footerRight !== null) { printSettings.footerStrRight = pageSettings.footerRight; } let printProgressListener = { onLocationChange(webProgress, request, location, flags) { }, onProgressChange(webProgress, request, curSelfProgress, maxSelfProgress, curTotalProgress, maxTotalProgress) { }, - onSecurityChange(webProgress, request, oldState, state, - contentBlockingLogJSON) { }, + onSecurityChange(webProgress, request, state) { }, onStateChange(webProgress, request, flags, status) { if ((flags & Ci.nsIWebProgressListener.STATE_STOP) && (flags & Ci.nsIWebProgressListener.STATE_IS_DOCUMENT)) { resolve(retval == 0 ? "saved" : "replaced"); } }, onStatusChange: function(webProgress, request, status, message) { if (status != 0) { resolve(retval == 0 ? "not_saved" : "not_replaced");
--- a/browser/components/shell/nsMacShellService.cpp +++ b/browser/components/shell/nsMacShellService.cpp @@ -179,19 +179,17 @@ NS_IMETHODIMP nsMacShellService::OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { return NS_OK; } NS_IMETHODIMP nsMacShellService::OnSecurityChange(nsIWebProgress* aWebProgress, - nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + nsIRequest* aRequest, uint32_t aState) { return NS_OK; } NS_IMETHODIMP nsMacShellService::OnStateChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, uint32_t aStateFlags, nsresult aStatus) { if (aStateFlags & STATE_STOP) {
--- a/docshell/base/nsDocShell.cpp +++ b/docshell/base/nsDocShell.cpp @@ -6625,18 +6625,17 @@ NS_IMETHODIMP nsDocShell::OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP nsDocShell::OnSecurityChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, - uint32_t aOldState, uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + uint32_t aState) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } nsresult nsDocShell::EndPageLoad(nsIWebProgress* aProgress, nsIChannel* aChannel, nsresult aStatus) { if (!aChannel) { return NS_ERROR_NULL_POINTER;
--- a/docshell/base/nsDocShellTreeOwner.cpp +++ b/docshell/base/nsDocShellTreeOwner.cpp @@ -689,19 +689,18 @@ nsDocShellTreeOwner::OnLocationChange(ns NS_IMETHODIMP nsDocShellTreeOwner::OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { return NS_OK; } NS_IMETHODIMP -nsDocShellTreeOwner::OnSecurityChange( - nsIWebProgress* aWebProgress, nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, const nsAString& aContentBlockingLogJSON) { +nsDocShellTreeOwner::OnSecurityChange(nsIWebProgress* aWebProgress, + nsIRequest* aRequest, uint32_t aState) { return NS_OK; } //***************************************************************************** // nsDocShellTreeOwner: Accessors //***************************************************************************** void nsDocShellTreeOwner::WebBrowser(nsWebBrowser* aWebBrowser) {
--- a/dom/browser-element/BrowserElementChildPreload.js +++ b/dom/browser-element/BrowserElementChildPreload.js @@ -1176,18 +1176,17 @@ BrowserElementChild.prototype = { } catch (e) {} sendAsyncMsg('error', { type: 'other' }); return; } } }, - onSecurityChange: function(webProgress, request, oldState, state, - contentBlockingLogJSON) { + onSecurityChange: function(webProgress, request, state) { if (webProgress != docShell) { return; } var securityStateDesc; if (state & Ci.nsIWebProgressListener.STATE_IS_SECURE) { securityStateDesc = 'secure'; }
--- a/dom/clients/manager/ClientNavigateOpChild.cpp +++ b/dom/clients/manager/ClientNavigateOpChild.cpp @@ -116,18 +116,17 @@ class NavigateLoadListener final : publi OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) override { MOZ_CRASH("Unexpected notification."); return NS_OK; } NS_IMETHOD OnSecurityChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, - uint32_t aOldState, uint32_t aState, - const nsAString& aContentBlockingLogJSON) override { + uint32_t aState) override { MOZ_CRASH("Unexpected notification."); return NS_OK; } NS_DECL_ISUPPORTS }; NS_IMPL_ISUPPORTS(NavigateLoadListener, nsIWebProgressListener,
--- a/dom/clients/manager/ClientOpenWindowUtils.cpp +++ b/dom/clients/manager/ClientOpenWindowUtils.cpp @@ -112,18 +112,17 @@ class WebProgressListener final : public OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) override { MOZ_ASSERT(false, "Unexpected notification."); return NS_OK; } NS_IMETHOD OnSecurityChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, - uint32_t aOldState, uint32_t aState, - const nsAString& aContentBlockingLogJSON) override { + uint32_t aState) override { MOZ_ASSERT(false, "Unexpected notification."); return NS_OK; } private: ~WebProgressListener() { if (mPromise) { mPromise->Reject(NS_ERROR_ABORT, __func__);
--- a/dom/html/HTMLFormElement.cpp +++ b/dom/html/HTMLFormElement.cpp @@ -1990,19 +1990,17 @@ HTMLFormElement::OnStatusChange(nsIWebPr nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP HTMLFormElement::OnSecurityChange(nsIWebProgress* aWebProgress, - nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + nsIRequest* aRequest, uint32_t state) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP_(int32_t) HTMLFormElement::IndexOfControl(nsIFormControl* aControl) { int32_t index = 0; return mControls->IndexOfControl(aControl, &index) == NS_OK ? index : 0;
--- a/dom/html/nsHTMLDNSPrefetch.cpp +++ b/dom/html/nsHTMLDNSPrefetch.cpp @@ -499,19 +499,19 @@ NS_IMETHODIMP nsHTMLDNSPrefetch::nsDeferrals::OnStatusChange(nsIWebProgress *aWebProgress, nsIRequest *aRequest, nsresult aStatus, const char16_t *aMessage) { return NS_OK; } NS_IMETHODIMP -nsHTMLDNSPrefetch::nsDeferrals::OnSecurityChange( - nsIWebProgress *aWebProgress, nsIRequest *aRequest, uint32_t aOldState, - uint32_t aState, const nsAString &aContentBlockingLogJSON) { +nsHTMLDNSPrefetch::nsDeferrals::OnSecurityChange(nsIWebProgress *aWebProgress, + nsIRequest *aRequest, + uint32_t state) { return NS_OK; } //////////// nsIObserver method NS_IMETHODIMP nsHTMLDNSPrefetch::nsDeferrals::Observe(nsISupports *subject, const char *topic, const char16_t *data) {
--- a/dom/presentation/PresentationCallbacks.cpp +++ b/dom/presentation/PresentationCallbacks.cpp @@ -230,13 +230,12 @@ PresentationResponderLoadingCallback::On nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { // Do nothing. return NS_OK; } NS_IMETHODIMP PresentationResponderLoadingCallback::OnSecurityChange( - nsIWebProgress* aWebProgress, nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, const nsAString& aContentBlockingLogJSON) { + nsIWebProgress* aWebProgress, nsIRequest* aRequest, uint32_t state) { // Do nothing. return NS_OK; }
--- a/editor/composer/nsEditingSession.cpp +++ b/editor/composer/nsEditingSession.cpp @@ -782,19 +782,17 @@ nsEditingSession::OnStatusChange(nsIWebP /*--------------------------------------------------------------------------- OnSecurityChange ----------------------------------------------------------------------------*/ NS_IMETHODIMP nsEditingSession::OnSecurityChange(nsIWebProgress* aWebProgress, - nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + nsIRequest* aRequest, uint32_t state) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } /*--------------------------------------------------------------------------- IsProgressForTargetDocument
--- a/editor/composer/test/test_bug434998.xul +++ b/editor/composer/test/test_bug434998.xul @@ -82,18 +82,17 @@ https://bugzilla.mozilla.org/show_bug.cg onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags) { }, onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage) { }, - onSecurityChange : function(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) + onSecurityChange : function(aWebProgress, aRequest, aState) { }, mEditor: null }; var progress, progressListener;
--- a/editor/libeditor/tests/test_bug607584.xul +++ b/editor/libeditor/tests/test_bug607584.xul @@ -88,18 +88,17 @@ https://bugzilla.mozilla.org/show_bug.cg onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags) { }, onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage) { }, - onSecurityChange : function(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) + onSecurityChange : function(aWebProgress, aRequest, aState) { }, mEditor: null }; var progress, progressListener;
--- a/editor/libeditor/tests/test_bug616590.xul +++ b/editor/libeditor/tests/test_bug616590.xul @@ -77,18 +77,17 @@ https://bugzilla.mozilla.org/show_bug.cg onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags) { }, onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage) { }, - onSecurityChange : function(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) + onSecurityChange : function(aWebProgress, aRequest, aState) { }, mEditor: null }; var progress, progressListener;
--- a/editor/libeditor/tests/test_bug780908.xul +++ b/editor/libeditor/tests/test_bug780908.xul @@ -86,18 +86,17 @@ adapted from test_bug607584.xul by Kent onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags) { }, onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage) { }, - onSecurityChange : function(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) + onSecurityChange : function(aWebProgress, aRequest, aState) { }, mEditor: null }; var progress, progressListener;
--- a/layout/base/tests/chrome/printpreview_bug396024_helper.xul +++ b/layout/base/tests/chrome/printpreview_bug396024_helper.xul @@ -18,18 +18,17 @@ var SimpleTest = window.opener.wrappedJS var gWbp; function printpreview() { gWbp = window.frames[1].docShell.printPreview; var listener = { onLocationChange: function(webProgress, request, location, flags) { }, onProgressChange: function(webProgress, request, curSelfProgress, maxSelfProgress, curTotalProgress, maxTotalProgress) { }, - onSecurityChange: function(webProgress, request, oldState, state, - contentBlockingLogJSON) { }, + onSecurityChange: function(webProgress, request, state) { }, onStateChange: function(webProgress, request, stateFlags, status) { }, onStatusChange: function(webProgress, request, status, message) { }, QueryInterface: function(iid) { if (iid.equals(Ci.nsIWebProgressListener) || iid.equals(Ci.nsISupportsWeakReference)) return this; throw Cr.NS_NOINTERFACE; }
--- a/layout/base/tests/chrome/printpreview_bug482976_helper.xul +++ b/layout/base/tests/chrome/printpreview_bug482976_helper.xul @@ -18,18 +18,17 @@ var SimpleTest = window.opener.wrappedJS var gWbp; function printpreview() { gWbp = window.frames[1].docShell.printPreview; var listener = { onLocationChange: function(webProgress, request, location, flags) { }, onProgressChange: function(webProgress, request, curSelfProgress, maxSelfProgress, curTotalProgress, maxTotalProgress) { }, - onSecurityChange: function(webProgress, request, oldState, state, - contentBlockingLogJSON) { }, + onSecurityChange: function(webProgress, request, state) { }, onStateChange: function(webProgress, request, stateFlags, status) { }, onStatusChange: function(webProgress, request, status, message) { }, QueryInterface: function(iid) { if (iid.equals(Ci.nsIWebProgessListener) || iid.equals(Ci.nsISupportsWeakReference)) return this; throw Cr.NS_NOINTERFACE; }
--- a/layout/base/tests/chrome/printpreview_helper.xul +++ b/layout/base/tests/chrome/printpreview_helper.xul @@ -25,18 +25,17 @@ filePath = file.path; function printpreview() { gWbp = window.frames[1].docShell.printPreview; var listener = { onLocationChange: function(webProgress, request, location, flags) { }, onProgressChange: function(webProgress, request, curSelfProgress, maxSelfProgress, curTotalProgress, maxTotalProgress) { }, - onSecurityChange: function(webProgress, request, oldState, state, - contentBlockingLogJSON) { }, + onSecurityChange: function(webProgress, request, state) { }, onStateChange: function(webProgress, request, stateFlags, status) { }, onStatusChange: function(webProgress, request, status, message) { }, QueryInterface: function(iid) { if (iid.equals(Ci.nsIWebProgressListener) || iid.equals(Ci.nsISupportsWeakReference)) return this; throw Cr.NS_NOINTERFACE; }
--- a/layout/printing/ipc/RemotePrintJobChild.cpp +++ b/layout/printing/ipc/RemotePrintJobChild.cpp @@ -134,19 +134,18 @@ RemotePrintJobChild::OnStatusChange(nsIW if (NS_SUCCEEDED(mInitializationResult) && !mDestroyed) { Unused << SendStatusChange(aStatus); } return NS_OK; } NS_IMETHODIMP -RemotePrintJobChild::OnSecurityChange( - nsIWebProgress* aProgress, nsIRequest* aRequest, uint32_t aState, - uint32_t aOldState, const nsAString& aContentBlockingLogJSON) { +RemotePrintJobChild::OnSecurityChange(nsIWebProgress* aProgress, + nsIRequest* aRequest, uint32_t aState) { return NS_OK; } // End of nsIWebProgressListener RemotePrintJobChild::~RemotePrintJobChild() {} void RemotePrintJobChild::ActorDestroy(ActorDestroyReason aWhy) {
--- a/layout/printing/nsPrintJob.cpp +++ b/layout/printing/nsPrintJob.cpp @@ -2013,18 +2013,17 @@ NS_IMETHODIMP nsPrintJob::OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP nsPrintJob::OnSecurityChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, - uint32_t aState, uint32_t aOldState, - const nsAString& aContentBlockingLogJSON) { + uint32_t aState) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } //------------------------------------------------------- void nsPrintJob::UpdateZoomRatio(nsPrintObject* aPO, bool aSetPixelScale) { // Here is where we set the shrinkage value into the DC
--- a/layout/tools/layout-debug/ui/content/layoutdebug.js +++ b/layout/tools/layout-debug/ui/content/layoutdebug.js @@ -72,18 +72,17 @@ nsLDBBrowserContentListener.prototype = this.setButtonEnabled(this.mBackButton, gBrowser.canGoBack); }, onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage) { this.mStatusText.value = aMessage; }, - onSecurityChange : function(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) + onSecurityChange : function(aWebProgress, aRequest, aState) { }, // non-interface methods setButtonEnabled : function(aButtonElement, aEnabled) { if (aEnabled) aButtonElement.removeAttribute("disabled");
--- a/mobile/android/chrome/content/browser.js +++ b/mobile/android/chrome/content/browser.js @@ -4720,18 +4720,17 @@ Tab.prototype = { Services.obs.notifyObservers(this.browser, "Session:NotifyLocationChange"); } }, // Properties used to cache security state used to update the UI _state: null, _hostChanged: false, // onLocationChange will flip this bit - onSecurityChange: function(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange: function(aWebProgress, aRequest, aState) { // Don't need to do anything if the data we use to update the UI hasn't changed if (this._state == aState && !this._hostChanged) return; this._state = aState; this._hostChanged = false; let identity = IdentityHandler.checkIdentity(aState, this.browser);
--- a/mobile/android/modules/geckoview/GeckoViewProgress.jsm +++ b/mobile/android/modules/geckoview/GeckoViewProgress.jsm @@ -248,18 +248,17 @@ class GeckoViewProgress extends GeckoVie type: "GeckoView:PageStop", success: isSuccess, }; this.eventDispatcher.sendRequest(message); } } - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, aState) { debug `onSecurityChange`; // Don't need to do anything if the data we use to update the UI hasn't changed if (this._state === aState && !this._hostChanged) { return; } this._state = aState;
--- a/mobile/android/modules/geckoview/GeckoViewTrackingProtection.jsm +++ b/mobile/android/modules/geckoview/GeckoViewTrackingProtection.jsm @@ -15,18 +15,17 @@ class GeckoViewTrackingProtection extend const flags = Ci.nsIWebProgress.NOTIFY_SECURITY; this.progressFilter = Cc["@mozilla.org/appshell/component/browser-status-filter;1"] .createInstance(Ci.nsIWebProgress); this.progressFilter.addProgressListener(this, flags); this.browser.addProgressListener(this.progressFilter, flags); } - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, aState) { debug `onSecurityChange`; if (!(aState & Ci.nsIWebProgressListener.STATE_BLOCKED_TRACKING_CONTENT) || !aRequest || !(aRequest instanceof Ci.nsIClassifiedChannel)) { return; } let channel = aRequest.QueryInterface(Ci.nsIChannel);
--- a/netwerk/base/nsISecureBrowserUI.idl +++ b/netwerk/base/nsISecureBrowserUI.idl @@ -9,40 +9,15 @@ interface nsIDocShell; interface nsITransportSecurityInfo; [scriptable, uuid(718c662a-f810-4a80-a6c9-0b1810ecade2)] interface nsISecureBrowserUI : nsISupports { void init(in nsIDocShell docShell); - // A value composed of the Security State Flags and the Security - // Strength Flags defined in nsIWebProgressListener. - // Any undefined bits are reserved for future use. - // This represents the security state before the change. - readonly attribute unsigned long oldState; - // A value composed of the Security State Flags and the Security - // Strength Flags defined in nsIWebProgressListener. - // Any undefined bits are reserved for future use. - // This represents the security state after the change. readonly attribute unsigned long state; - // An optional JSON string representing a log of the content blocking - // events happened so far. This will be a JSON object containing keys - // representing origins that content blocking has acted on, with values - // being an array of items, each representing one action. Each action - // itself is an an array containing three elements, the first element - // being a blocking code from one of the Security State Flags above, and - // the second element being a boolean representing whether the origin - // was blocked (if true) or unblocked (if false) in that category, and - // the third element being the number of times that combination has been - // repeated consecutively. - // The reason JSON strings was chosen here was that we needed a format - // that is transferrable across processes in JS; and also the consumer - // of this data (browser-contentblocking.js) would be able to use the - // JSON.parse() API to parse out an object representation of the value. - readonly attribute AString contentBlockingLogJSON; - // Information about the connection security. readonly attribute nsITransportSecurityInfo secInfo; }; %{C++ #define NS_SECURE_BROWSER_UI_CONTRACTID "@mozilla.org/secure_browser_ui;1" %}
--- a/security/manager/ssl/nsSecureBrowserUIImpl.cpp +++ b/security/manager/ssl/nsSecureBrowserUIImpl.cpp @@ -53,67 +53,32 @@ nsSecureBrowserUIImpl::Init(nsIDocShell* if (NS_FAILED(rv)) { return rv; } return wp->AddProgressListener(this, nsIWebProgress::NOTIFY_LOCATION); } NS_IMETHODIMP -nsSecureBrowserUIImpl::GetOldState(uint32_t* aOldState) { - MOZ_ASSERT(NS_IsMainThread()); - NS_ENSURE_ARG(aOldState); - - MOZ_LOG(gSecureBrowserUILog, LogLevel::Debug, ("GetOldState %p", this)); - // Only sync our state with the docshell in GetState(). - MOZ_LOG(gSecureBrowserUILog, LogLevel::Debug, (" mOldState: %x", mOldState)); - - *aOldState = mOldState; - return NS_OK; -} - -NS_IMETHODIMP nsSecureBrowserUIImpl::GetState(uint32_t* aState) { MOZ_ASSERT(NS_IsMainThread()); NS_ENSURE_ARG(aState); MOZ_LOG(gSecureBrowserUILog, LogLevel::Debug, ("GetState %p", this)); // With respect to mixed content and tracking protection, we won't know when // the state of our document (or a subdocument) has changed, so we ask the // docShell. CheckForBlockedContent(); MOZ_LOG(gSecureBrowserUILog, LogLevel::Debug, (" mState: %x", mState)); *aState = mState; return NS_OK; } NS_IMETHODIMP -nsSecureBrowserUIImpl::GetContentBlockingLogJSON( - nsAString& aContentBlockingLogJSON) { - MOZ_ASSERT(NS_IsMainThread()); - - MOZ_LOG(gSecureBrowserUILog, LogLevel::Debug, - ("GetContentBlockingLogJSON %p", this)); - aContentBlockingLogJSON.Truncate(); - nsCOMPtr<nsIDocShell> docShell = do_QueryReferent(mDocShell); - if (docShell) { - nsIDocument* doc = docShell->GetDocument(); - if (doc) { - aContentBlockingLogJSON = doc->GetContentBlockingLog()->Stringify(); - } - } - MOZ_LOG(gSecureBrowserUILog, LogLevel::Debug, - (" ContentBlockingLogJSON: %s", - NS_ConvertUTF16toUTF8(aContentBlockingLogJSON).get())); - - return NS_OK; -} - -NS_IMETHODIMP nsSecureBrowserUIImpl::GetSecInfo(nsITransportSecurityInfo** result) { MOZ_ASSERT(NS_IsMainThread()); NS_ENSURE_ARG_POINTER(result); *result = mTopLevelSecurityInfo; NS_IF_ADDREF(*result); return NS_OK; @@ -455,13 +420,12 @@ nsSecureBrowserUIImpl::OnProgressChange( NS_IMETHODIMP nsSecureBrowserUIImpl::OnStatusChange(nsIWebProgress*, nsIRequest*, nsresult, const char16_t*) { MOZ_ASSERT_UNREACHABLE("Should have been excluded in AddProgressListener()"); return NS_OK; } nsresult nsSecureBrowserUIImpl::OnSecurityChange(nsIWebProgress*, nsIRequest*, - uint32_t, uint32_t, - const nsAString&) { + uint32_t) { MOZ_ASSERT_UNREACHABLE("Should have been excluded in AddProgressListener()"); return NS_OK; }
--- a/toolkit/actors/PrintingChild.jsm +++ b/toolkit/actors/PrintingChild.jsm @@ -416,11 +416,10 @@ PrintingListener.prototype = { maxSelfProgress: aMaxSelfProgress, curTotalProgress: aCurTotalProgress, maxTotalProgress: aMaxTotalProgress, }); }, onLocationChange(aWebProgress, aRequest, aLocation, aFlags) {}, onStatusChange(aWebProgress, aRequest, aStatus, aMessage) {}, - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) {}, + onSecurityChange(aWebProgress, aRequest, aState) {}, };
--- a/toolkit/components/browser/nsWebBrowser.cpp +++ b/toolkit/components/browser/nsWebBrowser.cpp @@ -706,22 +706,19 @@ nsWebBrowser::OnStatusChange(nsIWebProgr return mProgressListener->OnStatusChange(aWebProgress, aRequest, aStatus, aMessage); } return NS_OK; } NS_IMETHODIMP nsWebBrowser::OnSecurityChange(nsIWebProgress* aWebProgress, - nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + nsIRequest* aRequest, uint32_t aState) { if (mProgressListener) { - return mProgressListener->OnSecurityChange( - aWebProgress, aRequest, aOldState, aState, aContentBlockingLogJSON); + return mProgressListener->OnSecurityChange(aWebProgress, aRequest, aState); } return NS_OK; } //***************************************************************************** // nsWebBrowser::nsIWebBrowserPersist //*****************************************************************************
--- a/toolkit/components/printing/content/printPreviewProgress.js +++ b/toolkit/components/printing/content/printPreviewProgress.js @@ -54,18 +54,17 @@ var progressListener = { if (docURLStr != docURL && dialog.title != null) { docURL = docURLStr; if (docTitle == "") dialog.title.value = docURLStr; } }, onLocationChange(aWebProgress, aRequest, aLocation, aFlags) {}, - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) {}, + onSecurityChange(aWebProgress, aRequest, state) {}, onStatusChange(aWebProgress, aRequest, aStatus, aMessage) { if (aMessage) dialog.title.setAttribute("value", aMessage); }, QueryInterface: ChromeUtils.generateQI(["nsIWebProgressListener", "nsISupportsWeakReference"]),
--- a/toolkit/components/printing/content/printProgress.js +++ b/toolkit/components/printing/content/printProgress.js @@ -135,18 +135,17 @@ var progressListener = { // we can ignore this notification }, onStatusChange(aWebProgress, aRequest, aStatus, aMessage) { if (aMessage != "") dialog.title.setAttribute("value", aMessage); }, - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, state) { // we can ignore this notification }, QueryInterface: ChromeUtils.generateQI(["nsIWebProgressListener", "nsISupportsWeakReference"]), }; function getString( stringId ) {
--- a/toolkit/components/printingui/ipc/PrintProgressDialogChild.cpp +++ b/toolkit/components/printingui/ipc/PrintProgressDialogChild.cpp @@ -77,19 +77,19 @@ PrintProgressDialogChild::OnLocationChan NS_IMETHODIMP PrintProgressDialogChild::OnStatusChange(nsIWebProgress* aProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { return NS_OK; } NS_IMETHODIMP -PrintProgressDialogChild::OnSecurityChange( - nsIWebProgress* aProgress, nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, const nsAString& aContentBlockingLogJSON) { +PrintProgressDialogChild::OnSecurityChange(nsIWebProgress* aProgress, + nsIRequest* aRequest, + uint32_t aState) { return NS_OK; } // nsIPrintProgressParams NS_IMETHODIMP PrintProgressDialogChild::GetDocTitle(nsAString& aDocTitle) { aDocTitle = mDocTitle;
--- a/toolkit/components/printingui/nsPrintProgress.cpp +++ b/toolkit/components/printingui/nsPrintProgress.cpp @@ -238,19 +238,19 @@ NS_IMETHODIMP nsPrintProgress::OnStatusC if (progressListener) progressListener->OnStatusChange(aWebProgress, aRequest, aStatus, aMessage); } return NS_OK; } -NS_IMETHODIMP nsPrintProgress::OnSecurityChange( - nsIWebProgress *aWebProgress, nsIRequest *aRequest, uint32_t aOldState, - uint32_t aState, const nsAString &aContentBlockingLogJSON) { +NS_IMETHODIMP nsPrintProgress::OnSecurityChange(nsIWebProgress *aWebProgress, + nsIRequest *aRequest, + uint32_t state) { return NS_OK; } nsresult nsPrintProgress::ReleaseListeners() { m_listenerList.Clear(); return NS_OK; }
--- a/toolkit/components/printingui/nsPrintingPromptService.cpp +++ b/toolkit/components/printingui/nsPrintingPromptService.cpp @@ -198,19 +198,19 @@ nsPrintingPromptService::OnStatusChange( return mWebProgressListener->OnStatusChange(aWebProgress, aRequest, aStatus, aMessage); } #endif return NS_OK; } NS_IMETHODIMP -nsPrintingPromptService::OnSecurityChange( - nsIWebProgress* aWebProgress, nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, const nsAString& aContentBlockingLogJSON) { +nsPrintingPromptService::OnSecurityChange(nsIWebProgress* aWebProgress, + nsIRequest* aRequest, + uint32_t state) { #if !defined(XP_MACOSX) if (mWebProgressListener) { - return mWebProgressListener->OnSecurityChange( - aWebProgress, aRequest, aOldState, aState, aContentBlockingLogJSON); + return mWebProgressListener->OnSecurityChange(aWebProgress, aRequest, + state); } #endif return NS_OK; }
--- a/toolkit/components/statusfilter/nsBrowserStatusFilter.cpp +++ b/toolkit/components/statusfilter/nsBrowserStatusFilter.cpp @@ -229,23 +229,21 @@ nsBrowserStatusFilter::OnStatusChange(ns } mDelayedStatus = true; return NS_OK; } NS_IMETHODIMP -nsBrowserStatusFilter::OnSecurityChange( - nsIWebProgress *aWebProgress, nsIRequest *aRequest, uint32_t aOldState, - uint32_t aState, const nsAString &aContentBlockingLogJSON) { +nsBrowserStatusFilter::OnSecurityChange(nsIWebProgress *aWebProgress, + nsIRequest *aRequest, uint32_t aState) { if (!mListener) return NS_OK; - return mListener->OnSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON); + return mListener->OnSecurityChange(aWebProgress, aRequest, aState); } //----------------------------------------------------------------------------- // nsBrowserStatusFilter::nsIWebProgressListener2 //----------------------------------------------------------------------------- NS_IMETHODIMP nsBrowserStatusFilter::OnProgressChange64(nsIWebProgress *aWebProgress, nsIRequest *aRequest,
--- a/toolkit/components/url-classifier/tests/mochitest/test_threathit_report.html +++ b/toolkit/components/url-classifier/tests/mochitest/test_threathit_report.html @@ -189,18 +189,17 @@ function testOnWindow(aTestData) { (async function() { await new Promise(rs => whenDelayedStartupFinished(win, rs)); let expected; let browser = win.gBrowser.selectedBrowser; let wp = win.gBrowser.contentWindow.docShell.QueryInterface(Ci.nsIWebProgress); let progressListener = { - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, aState) { expected = aTestData.reportUrl; }, QueryInterface: ChromeUtils.generateQI(["nsISupportsWeakReference"]), }; wp.addProgressListener(progressListener, wp.NOTIFY_SECURITY); await BrowserTestUtils.loadURI(browser, aTestData.url); await BrowserTestUtils.waitForContentEvent(browser, "DOMContentLoaded");
--- a/toolkit/modules/RemoteSecurityUI.jsm +++ b/toolkit/modules/RemoteSecurityUI.jsm @@ -2,30 +2,24 @@ // This Source Code Form is subject to the terms of the Mozilla Public // License, v. 2.0. If a copy of the MPL was not distributed with this // file, You can obtain one at http://mozilla.org/MPL/2.0/. var EXPORTED_SYMBOLS = ["RemoteSecurityUI"]; function RemoteSecurityUI() { this._secInfo = null; - this._oldState = 0; this._state = 0; - this._contentBlockingLogJSON = ""; } RemoteSecurityUI.prototype = { QueryInterface: ChromeUtils.generateQI([Ci.nsISecureBrowserUI]), // nsISecureBrowserUI - get oldState() { return this._oldState; }, get state() { return this._state; }, - get contentBlockingLogJSON() { return this._contentBlockingLogJSON; }, get tooltipText() { return ""; }, get secInfo() { return this._secInfo; }, - _update(aSecInfo, aOldState, aState, aContentBlockingLogJSON) { + _update(aSecInfo, aState) { this._secInfo = aSecInfo; - this._oldState = aOldState; this._state = aState; - this._contentBlockingLogJSON = aContentBlockingLogJSON; }, };
--- a/toolkit/modules/RemoteWebProgress.jsm +++ b/toolkit/modules/RemoteWebProgress.jsm @@ -114,27 +114,27 @@ RemoteWebProgressManager.prototype = { }); }, removeProgressListener(aListener) { this._progressListeners = this._progressListeners.filter(l => l.listener != aListener); }, - _fixSecInfo(aSecInfo) { + _fixSecInfoAndState(aSecInfo, aState) { let deserialized = null; if (aSecInfo) { let helper = Cc["@mozilla.org/network/serialization-helper;1"] .getService(Ci.nsISerializationHelper); deserialized = helper.deserializeObject(aSecInfo); deserialized.QueryInterface(Ci.nsITransportSecurityInfo); } - return deserialized; + return [deserialized, aState]; }, setCurrentURI(aURI) { // This function is simpler than nsDocShell::SetCurrentURI since // it doesn't have to deal with child docshells. let remoteWebNav = this._browser._remoteWebNavigationImpl; remoteWebNav._currentURI = aURI; @@ -239,33 +239,29 @@ RemoteWebProgressManager.prototype = { this._callProgressListeners( Ci.nsIWebProgress.NOTIFY_LOCATION, "onLocationChange", webProgress, request, location, flags ); break; case "Content:SecurityChange": - let secInfo = this._fixSecInfo(json.secInfo); - let oldState = json.oldState; - let state = json.state; - let contentBlockingLogJSON = json.contentBlockingLogJSON; + let [secInfo, state] = this._fixSecInfoAndState(json.secInfo, json.state); if (isTopLevel) { // Invoking this getter triggers the generation of the underlying object, // which we need to access with ._securityUI, because .securityUI returns // a wrapper that makes _update inaccessible. void this._browser.securityUI; - this._browser._securityUI._update(secInfo, oldState, state, - contentBlockingLogJSON); + this._browser._securityUI._update(secInfo, state); } this._callProgressListeners( Ci.nsIWebProgress.NOTIFY_SECURITY, "onSecurityChange", webProgress, - request, oldState, state, contentBlockingLogJSON + request, state ); break; case "Content:StatusChange": this._callProgressListeners( Ci.nsIWebProgress.NOTIFY_STATUS, "onStatusChange", webProgress, request, json.status, json.message );
--- a/toolkit/modules/WebProgressChild.jsm +++ b/toolkit/modules/WebProgressChild.jsm @@ -183,24 +183,21 @@ class WebProgressChild { let secInfo = this.mm.docShell.securityUI.secInfo; if (secInfo) { return serializationHelper.serializeToString(secInfo); } return null; } - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, aState) { let json = this._setupJSON(aWebProgress, aRequest); - json.oldState = aOldState; json.state = aState; json.secInfo = this.getSecInfoAsString(); - json.contentBlockingLogJSON = aContentBlockingLogJSON; json.matchedList = null; if (aRequest && aRequest instanceof Ci.nsIClassifiedChannel) { json.matchedList = aRequest.matchedList; } this._send("Content:SecurityChange", json); }
--- a/toolkit/mozapps/downloads/nsHelperAppDlg.js +++ b/toolkit/mozapps/downloads/nsHelperAppDlg.js @@ -65,18 +65,17 @@ nsUnknownContentTypeDialogProgressListen onStateChange(aWebProgress, aRequest, aStateFlags, aStatus) { }, onLocationChange(aWebProgress, aRequest, aLocation, aFlags) { }, - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, state) { }, onRefreshAttempted(aWebProgress, aURI, aDelay, aSameURI) { return true; }, }; // /////////////////////////////////////////////////////////////////////////////
--- a/toolkit/mozapps/extensions/content/extensions.js +++ b/toolkit/mozapps/extensions/content/extensions.js @@ -2181,18 +2181,17 @@ var gDiscoverView = { (!this.homepageURL.schemeIs("https") || aLocation.schemeIs("https"))) return; // Canceling the request will send an error to onStateChange which will show // the error page aRequest.cancel(Cr.NS_BINDING_ABORTED); }, - onSecurityChange(aWebProgress, aRequest, aOldState, aState, - aContentBlockingLogJSON) { + onSecurityChange(aWebProgress, aRequest, aState) { // Don't care about security if the page is not https if (!this.homepageURL.schemeIs("https")) return; // If the request was secure then it is ok if (aState & Ci.nsIWebProgressListener.STATE_IS_SECURE) return;
--- a/uriloader/base/nsDocLoader.cpp +++ b/uriloader/base/nsDocLoader.cpp @@ -1398,22 +1398,19 @@ NS_IMETHODIMP nsDocLoader::OnSecurityCha nsISupports* aContext, uint32_t aOldState, uint32_t aState, ContentBlockingLog* aContentBlockingLog) { // // Fire progress notifications out to any registered nsIWebProgressListeners. // nsCOMPtr<nsIRequest> request = do_QueryInterface(aContext); nsIWebProgress* webProgress = static_cast<nsIWebProgress*>(this); - nsAutoString contentBlockingLogJSON( - aContentBlockingLog ? aContentBlockingLog->Stringify() : EmptyString()); NOTIFY_LISTENERS(nsIWebProgress::NOTIFY_SECURITY, - listener->OnSecurityChange(webProgress, request, aOldState, - aState, contentBlockingLogJSON);); + listener->OnSecurityChange(webProgress, request, aState);); // Pass the notification up to the parent... if (mParent) { mParent->OnSecurityChange(aContext, aOldState, aState, aContentBlockingLog); } return NS_OK; }
--- a/uriloader/base/nsIWebProgressListener.idl +++ b/uriloader/base/nsIWebProgressListener.idl @@ -466,37 +466,20 @@ interface nsIWebProgressListener : nsISu * security transitions (eg HTTP -> HTTPS, HTTPS -> HTTP, FOO -> HTTPS) and * after document load completion. It might also be called if an error * occurs during network loading. * * @param aWebProgress * The nsIWebProgress instance that fired the notification. * @param aRequest * The nsIRequest that has new security state. - * @param aOldState - * A value composed of the Security State Flags and the Security - * Strength Flags listed above. Any undefined bits are reserved for - * future use. This represents the security state before the change. * @param aState * A value composed of the Security State Flags and the Security * Strength Flags listed above. Any undefined bits are reserved for - * future use. This represents the security state after the change. - * @param aContentBlockingLog - * An optional JSON string representing a log of the content blocking - * events happened so far. This will be a JSON object containing keys - * representing origins that content blocking has acted on, with values - * being an array of items, each representing one action. Each action - * itself is an an array containing three elements, the first element - * being a blocking code from one of the Security State Flags above, and - * the second element being a boolean representing whether the origin - * was blocked (if true) or unblocked (if false) in that category, and - * the third element being the number of times that combination has been - * repeated consecutively. + * future use. * * NOTE: These notifications will only occur if a security package is * installed. */ void onSecurityChange(in nsIWebProgress aWebProgress, in nsIRequest aRequest, - in unsigned long aOldState, - in unsigned long aState, - in AString aContentBlockingLogJSON); + in unsigned long aState); };
--- a/uriloader/prefetch/nsOfflineCacheUpdateService.cpp +++ b/uriloader/prefetch/nsOfflineCacheUpdateService.cpp @@ -207,19 +207,19 @@ nsOfflineCachePendingUpdate::OnStatusCha nsIRequest *aRequest, nsresult aStatus, const char16_t *aMessage) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP -nsOfflineCachePendingUpdate::OnSecurityChange( - nsIWebProgress *aWebProgress, nsIRequest *aRequest, uint32_t aOldState, - uint32_t aState, const nsAString &aContentBlockingLogJSON) { +nsOfflineCachePendingUpdate::OnSecurityChange(nsIWebProgress *aWebProgress, + nsIRequest *aRequest, + uint32_t state) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } //----------------------------------------------------------------------------- // nsOfflineCacheUpdateService::nsISupports //-----------------------------------------------------------------------------
--- a/uriloader/prefetch/nsPrefetchService.cpp +++ b/uriloader/prefetch/nsPrefetchService.cpp @@ -914,19 +914,17 @@ nsPrefetchService::OnStatusChange(nsIWeb nsIRequest *aRequest, nsresult aStatus, const char16_t *aMessage) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP nsPrefetchService::OnSecurityChange(nsIWebProgress *aWebProgress, - nsIRequest *aRequest, uint32_t aOldState, - uint32_t aState, - const nsAString &aContentBlockingLogJSON) { + nsIRequest *aRequest, uint32_t state) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } //----------------------------------------------------------------------------- // nsPrefetchService::nsIObserver //-----------------------------------------------------------------------------
--- a/xpfe/appshell/nsChromeTreeOwner.cpp +++ b/xpfe/appshell/nsChromeTreeOwner.cpp @@ -440,19 +440,17 @@ NS_IMETHODIMP nsChromeTreeOwner::OnStatusChange(nsIWebProgress* aWebProgress, nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { return NS_OK; } NS_IMETHODIMP nsChromeTreeOwner::OnSecurityChange(nsIWebProgress* aWebProgress, - nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + nsIRequest* aRequest, uint32_t state) { return NS_OK; } //***************************************************************************** // nsChromeTreeOwner: Helpers //***************************************************************************** //*****************************************************************************
--- a/xpfe/appshell/nsWebShellWindow.cpp +++ b/xpfe/appshell/nsWebShellWindow.cpp @@ -624,19 +624,17 @@ nsWebShellWindow::OnStatusChange(nsIWebP nsIRequest* aRequest, nsresult aStatus, const char16_t* aMessage) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } NS_IMETHODIMP nsWebShellWindow::OnSecurityChange(nsIWebProgress* aWebProgress, - nsIRequest* aRequest, uint32_t aOldState, - uint32_t aState, - const nsAString& aContentBlockingLogJSON) { + nsIRequest* aRequest, uint32_t state) { MOZ_ASSERT_UNREACHABLE("notification excluded in AddProgressListener(...)"); return NS_OK; } /** * ExecuteCloseHandler - Run the close handler, if any. * @return true iff we found a close handler to run. */