Bug 1629030 - make line height changes actually take effect in reader mode, r=jaws
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 22 May 2020 19:55:37 +0000
changeset 531706 82160fd55e1fa8106c636657cfe4ddeb16864ad4
parent 531705 8783aa871d5e71f52fd8543882a893441c7d3375
child 531707 63a158b481ea7a28c812ccc5d29bdbe5fc1812bf
push id37442
push userncsoregi@mozilla.com
push dateSat, 23 May 2020 09:21:24 +0000
treeherdermozilla-central@bbcc193fe0f0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1629030
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1629030 - make line height changes actually take effect in reader mode, r=jaws The fact that CSS set a fixed line-height on an inner element meant that the main body of the reader mode text was not changing line height based on the CSS variable we set on a container higher in the DOM hierarchy. Differential Revision: https://phabricator.services.mozilla.com/D76310
toolkit/themes/shared/aboutReader.css
--- a/toolkit/themes/shared/aboutReader.css
+++ b/toolkit/themes/shared/aboutReader.css
@@ -658,17 +658,16 @@ button:disabled {
 
 /* Note that any class names from the original article that we want to match on
  * must be added to CLASSES_TO_PRESERVE in ReaderMode.jsm, so that
  * Readability.js doesn't strip them out */
 
 .moz-reader-content {
   display: none;
   font-size: 1em;
-  line-height: 1.6em;
 }
 
 @media print {
   .moz-reader-content p,
   .moz-reader-content code,
   .moz-reader-content pre,
   .moz-reader-content blockquote,
   .moz-reader-content ul,