Kick tinderboxen out of a Linux orange that looks bogus
authorJeff Walden <jwalden@mit.edu>
Sat, 18 Apr 2009 22:09:37 -0700
changeset 27543 8204ad28e890ac110ac4904f430bc38e619a01ba
parent 27542 6ab042310fb47c632821f02d11af0548f43c678b
child 27544 f4662701526b6c7d3402fdd8021b576a295218ec
push id6604
push userrsayre@mozilla.com
push dateMon, 20 Apr 2009 18:44:02 +0000
treeherdermozilla-central@83068fe4a1ec [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone1.9.2a1pre
Kick tinderboxen out of a Linux orange that looks bogus
js/src/jsarray.cpp
--- a/js/src/jsarray.cpp
+++ b/js/src/jsarray.cpp
@@ -97,17 +97,22 @@
 
 /* 2^32 - 1 as a number and a string */
 #define MAXINDEX 4294967295u
 #define MAXSTR   "4294967295"
 
 /* Small arrays are dense, no matter what. */
 #define MIN_SPARSE_INDEX 256
 
-#define INDEX_TOO_BIG(index) ((index) > JS_BIT(29) - 1)
+static inline bool
+INDEX_TOO_BIG(jsuint index)
+{
+    return index > JS_BIT(29) - 1;
+}
+
 #define INDEX_TOO_SPARSE(array, index)                                         \
     (INDEX_TOO_BIG(index) ||                                                   \
      ((index) > js_DenseArrayCapacity(array) && (index) >= MIN_SPARSE_INDEX && \
       (index) > (uint32)((array)->fslots[JSSLOT_ARRAY_COUNT] + 1) * 4))
 
 JS_STATIC_ASSERT(sizeof(JSScopeProperty) > 4 * sizeof(jsval));
 
 #define ENSURE_SLOW_ARRAY(cx, obj)                                             \