Bug 831307: Log breakpoint-level IPC errors always. r=dougt,jdm,jst a=blocking-b2g
authorChris Jones <jones.chris.g@gmail.com>
Wed, 16 Jan 2013 19:47:21 -0800
changeset 119116 81f41dd974c45b43e37ee425d23c793b299669c3
parent 119115 64450d6fee962d0210848a586033a1ac90ecd6cd
child 119117 da5cae51b8334f4597160fd74c9b823a621497f0
push id24189
push useremorley@mozilla.com
push dateThu, 17 Jan 2013 10:42:06 +0000
treeherdermozilla-central@712eca11a04e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdougt, jdm, jst, blocking-b2g
bugs831307
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 831307: Log breakpoint-level IPC errors always. r=dougt,jdm,jst a=blocking-b2g
ipc/glue/ProtocolUtils.h
--- a/ipc/glue/ProtocolUtils.h
+++ b/ipc/glue/ProtocolUtils.h
@@ -110,19 +110,20 @@ LoggingEnabled()
 #else
     return false;
 #endif
 }
 
 inline void
 ProtocolErrorBreakpoint(const char* aMsg)
 {
-    if (LoggingEnabled()) {
-        printf_stderr("Protocol error: %s\n", aMsg);
-    }
+    // Bugs that generate these error messages can be tough to
+    // reproduce.  Log always in the hope that someone finds the error
+    // message.
+    printf_stderr("IPDL protocol error: %s\n", aMsg);
 }
 
 typedef IPCMessageStart ProtocolId;
 
 struct PrivateIPDLInterface {};
 
 bool
 Bridge(const PrivateIPDLInterface&,