Bug 616591 followup to fix a comment., a=DONTBUILD
authorBoris Zbarsky <bzbarsky@mit.edu>
Wed, 08 Dec 2010 21:01:17 -0500
changeset 58922 81aea2200c34b1af0be136acfacd7405ed41f58a
parent 58921 4fccdd4bc023c116a4e4cdb43f1c04f2517349fd
child 58923 f236810876e7e862fe1f144b98d81448cb2dbf9f
push id17468
push userbzbarsky@mozilla.com
push dateThu, 09 Dec 2010 02:15:34 +0000
treeherdermozilla-central@81aea2200c34 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersDONTBUILD
bugs616591
milestone2.0b8pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 616591 followup to fix a comment., a=DONTBUILD
netwerk/protocol/http/nsHttpPipeline.cpp
--- a/netwerk/protocol/http/nsHttpPipeline.cpp
+++ b/netwerk/protocol/http/nsHttpPipeline.cpp
@@ -529,17 +529,19 @@ nsHttpPipeline::Close(nsresult reason)
         for (i=1; i<count; ++i) {
             trans = Response(i);
             trans->Close(NS_ERROR_NET_RESET);
             NS_RELEASE(trans);
         }
         mResponseQ.Clear();
     }
 
-    // we must no longer reference the connection!
+    // we must no longer reference the connection!  This needs to come
+    // after we've closed all our transactions, since they might want
+    // connection info as they close.
     NS_IF_RELEASE(mConnection);
 }
 
 nsresult
 nsHttpPipeline::OnReadSegment(const char *segment,
                               PRUint32 count,
                               PRUint32 *countRead)
 {