Bug 588817 - Using "Bookmark all tabs" initially mislabels new folder menuitem in Bookmarks menu (Test). r=gavin a=blocking-betaN
authorMargaret Leibovic <margaret.leibovic@gmail.com>
Fri, 05 Nov 2010 14:03:42 -0700
changeset 56969 813f49e7a76e89f30565a20e0a53fbe8be7a9a8e
parent 56968 e614fa32b2e21f59de20ce2221ce277a1180fc9d
child 56970 726e585dd529185122fa09053b880738e1c89379
push id16741
push usermargaret.leibovic@gmail.com
push dateFri, 05 Nov 2010 21:25:12 +0000
treeherdermozilla-central@c609be50b0b2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin, blocking-betaN
bugs588817
milestone2.0b8pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 588817 - Using "Bookmark all tabs" initially mislabels new folder menuitem in Bookmarks menu (Test). r=gavin a=blocking-betaN
browser/components/places/tests/browser/browser_views_liveupdate.js
--- a/browser/components/places/tests/browser/browser_views_liveupdate.js
+++ b/browser/components/places/tests/browser/browser_views_liveupdate.js
@@ -286,18 +286,18 @@ var bookmarksObserver = {
         let cellText = tree.view.getCellText(aElementOrTreeIndex,
                                              tree.columns.getColumnAt(0));
         if (!aNewValue)
           return cellText == PlacesUIUtils.getBestTitle(tree.view.nodeForTreeIndex(aElementOrTreeIndex));
         return cellText == aNewValue;
       }
       else {
         if (!aNewValue && aElementOrTreeIndex.localName != "toolbarbutton")
-          return aElementOrTreeIndex.label == PlacesUIUtils.getBestTitle(aElementOrTreeIndex._placesNode);
-        return aElementOrTreeIndex.label == aNewValue;
+          return aElementOrTreeIndex.getAttribute("label") == PlacesUIUtils.getBestTitle(aElementOrTreeIndex._placesNode);
+        return aElementOrTreeIndex.getAttribute("label") == aNewValue;
       }
     };
 
     for (var i = 0; i < views.length; i++) {
       var [node, index, valid] = searchItemInView(aItemId, views[i], validator);
       isnot(node, null, "Found changed Places node in " + views[i]);
       is(node.title, aNewValue, "Node has correct title: " + aNewValue);
       ok(valid, "Node element has correct label: " + aNewValue);