Bug 1452924 - Remove duplicate condition variable notification after running parallel GC task r=jandem
authorJon Coppeard <jcoppeard@mozilla.com>
Wed, 11 Apr 2018 10:55:18 +0100
changeset 412802 8014105bae53b2a4e90918e9762b0067494b4516
parent 412801 9422362ff3fd216a47bd7973c8d37eff5c06e95d
child 412803 1b0a61c9da091a06c125e8bb4fb7d7709df4f52a
push id33818
push userapavel@mozilla.com
push dateWed, 11 Apr 2018 14:36:40 +0000
treeherdermozilla-central@cfe6399e142c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1452924
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1452924 - Remove duplicate condition variable notification after running parallel GC task r=jandem
js/src/vm/HelperThreads.cpp
--- a/js/src/vm/HelperThreads.cpp
+++ b/js/src/vm/HelperThreads.cpp
@@ -1494,17 +1494,16 @@ HelperThread::handleGCParallelWorkload(A
     MOZ_ASSERT(idle());
 
     TraceLoggerThread* logger = TraceLoggerForCurrentThread();
     AutoTraceLog logCompile(logger, TraceLogger_GC);
 
     currentTask.emplace(HelperThreadState().gcParallelWorklist(locked).popCopy());
     gcParallelTask()->runFromHelperThread(locked);
     currentTask.reset();
-    HelperThreadState().notifyAll(GlobalHelperThreadState::CONSUMER, locked);
 }
 
 static void
 LeaveParseTaskZone(JSRuntime* rt, ParseTask* task)
 {
     // Mark the zone as no longer in use by a helper thread, and available
     // to be collected by the GC.
     rt->clearUsedByHelperThread(task->parseGlobal->zoneFromAnyThread());