Bug 1623328 Handle missing target_task_set in try estimates r=ahal
authorSimon Fraser <sfraser@mozilla.com>
Tue, 24 Mar 2020 16:39:37 +0000
changeset 520337 7fcd3948e2db2aa0e6e26061e3169366f080f351
parent 520336 0c79992b340e1181ce949686c1eba6b6cf5d79c5
child 520338 cd2bb1ad6ccb23ad0fc33cfe1d9f708fae1bbba0
push id37248
push userbtara@mozilla.com
push dateWed, 25 Mar 2020 16:40:49 +0000
treeherdermozilla-central@c5112a7573ac [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahal
bugs1623328
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1623328 Handle missing target_task_set in try estimates r=ahal I'm unsure of the root cause as the file should exist if generate_tasks has worked, but this should avoid errors in the meantime while we investigate. Differential Revision: https://phabricator.services.mozilla.com/D67833
tools/tryselect/util/manage_estimates.py
--- a/tools/tryselect/util/manage_estimates.py
+++ b/tools/tryselect/util/manage_estimates.py
@@ -96,17 +96,17 @@ def make_trimmed_taskgraph_cache(graph_c
     """Trim the taskgraph cache used for dependencies.
 
     Speeds up the fzf preview window to less human-perceptible
     ranges."""
     if not os.path.isfile(graph_cache):
         return
 
     target_task_set = set()
-    if target_file:
+    if target_file and os.path.isfile(target_file):
         with open(target_file) as f:
             target_task_set = set(json.load(f).keys())
 
     with open(graph_cache) as f:
         graph = json.load(f)
     graph = {
         name: list(defn['dependencies'].values())
         for name, defn in graph.items()