Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r=janv
authorRobert Bartlensky <rbartlensky@mozilla.com>
Thu, 19 Jul 2018 13:36:33 +0100
changeset 427373 7f73954c5633
parent 427372 74538c63a6a9
child 427374 d7e4562538d3
push id34303
push usertoros@mozilla.com
push dateFri, 20 Jul 2018 09:55:38 +0000
treeherdermozilla-central@47f713574cb2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjanv
bugs1476603
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r=janv MozReview-Commit-ID: B6oqb3tp3ND
dom/indexedDB/ActorsParent.cpp
--- a/dom/indexedDB/ActorsParent.cpp
+++ b/dom/indexedDB/ActorsParent.cpp
@@ -3939,16 +3939,19 @@ UpgradeIndexDataValuesFunction::OnFuncti
   rv = ReadOldCompressedIDVFromBlob(oldBlob, oldBlobLength, oldIdv);
   if (NS_WARN_IF(NS_FAILED(rv))) {
     return rv;
   }
 
   UniqueFreePtr<uint8_t> newIdv;
   uint32_t newIdvLength;
   rv = MakeCompressedIndexDataValues(oldIdv, newIdv, &newIdvLength);
+  if (NS_WARN_IF(NS_FAILED(rv))) {
+    return rv;
+  }
 
   std::pair<uint8_t*, int> data(newIdv.release(), newIdvLength);
 
   nsCOMPtr<nsIVariant> result = new storage::AdoptedBlobVariant(data);
 
   result.forget(aResult);
   return NS_OK;
 }