Bug 1622019 [wpt PR 22220] - Revert "rtcpeerconnection: dont fire signalingstatechange from close()", a=testonly
authorHenrik Boström <hbos@chromium.org>
Sat, 14 Mar 2020 11:28:12 +0000
changeset 518835 7f39fa2a2626c839fd32230e6f254f2009d56fe5
parent 518834 615472b72a74b59c1221ddffdade622f437fee36
child 518836 de8e977f2569f494a95830e63c57d280225e2e71
push id37217
push userccoroiu@mozilla.com
push dateSun, 15 Mar 2020 21:37:59 +0000
treeherdermozilla-central@f9fc9427476e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1622019, 22220, 2097979, 699036, 1959042, 727965, 1060547, 2100973, 749842
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1622019 [wpt PR 22220] - Revert "rtcpeerconnection: dont fire signalingstatechange from close()", a=testonly Automatic update from web-platform-tests Revert "rtcpeerconnection: dont fire signalingstatechange from close()" This reverts commit e8e1bf919cd15279406f11e5c2418f5d70fa897e. Reason for revert: Breaks detecting if pc closed for other reasons, like laptop lid closing. This CL should be re-landed with the following fix incorporated: https://chromium-review.googlesource.com/c/chromium/src/+/2097979 Original change's description: > rtcpeerconnection: dont fire signalingstatechange from close() > > RTCPeerConnection.close() shall not fire events. It doesn't already for > iceconnectionstate/connectionstate > > BUG=699036 > > Change-Id: I771cdd81c3bbdb4312a623e96f8150be8471d906 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959042 > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727965} TBR=hta@chromium.org,guidou@chromium.org,philipp.hancke@googlemail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 699036, 1060547 Change-Id: I85312331cb91fc7bc78326b8c86c68bca7d06e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100973 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#749842} -- wpt-commits: 13587fef36cd1df92d3e38d6e5916b380e971857 wpt-pr: 22220
testing/web-platform/tests/webrtc/RTCPeerConnection-close.html
deleted file mode 100644
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-close.html
+++ /dev/null
@@ -1,18 +0,0 @@
-<!doctype html>
-<meta charset=utf-8>
-<title>RTCPeerConnection.prototype.close</title>
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script>
-'use strict';
-
-  promise_test(async t => {
-    const pc = new RTCPeerConnection();
-    t.add_cleanup(() => pc.close());
-
-    pc.onsignalingstatechange = t.unreached_func();
-    pc.close();
-    assert_true(pc.signalingState === 'closed');
-    await new Promise(r => t.step_timeout(r, 100));
-  }, 'RTCPeerConnection.close() does not fire signalingstatechange event.');
-</script>