Bug 1471744 [wpt PR 11697] - [LayoutNG] Non-"inline" abspos needs to ignore floats and text-indent., a=testonly
authorMorten Stenshorne <mstensho@chromium.org>
Fri, 06 Jul 2018 23:17:14 +0000
changeset 426091 7ecfa735133e6ad288e14a85cce7849ca27493eb
parent 426090 1eb6b94f3c5ee50b056d1d91ed93181a98bc5640
child 426092 0087baa1e21b2ad446d03b795823654dd52f3ad0
push id34267
push userrgurzau@mozilla.com
push dateWed, 11 Jul 2018 22:05:21 +0000
treeherdermozilla-central@3aca103e4915 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1471744, 11697, 734554, 1116959, 571054
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1471744 [wpt PR 11697] - [LayoutNG] Non-"inline" abspos needs to ignore floats and text-indent., a=testonly Automatic update from web-platform-tests[LayoutNG] Non-"inline" abspos needs to ignore floats and text-indent. This fixes two tests, but will also eventually benefit floats-wrap-inside-inline-00[1234].htm in fast/block/float/, which are currently passing because the absolutely positioned box in the test forces its container to have block children. There's special-code for NG (which we should remove) in LayoutBlockFlow::AddChild() that forces this (and causes other problems). Added a new test, to make it clear what this fix is about. Bug: 734554 Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng Change-Id: Ia2c0e0b2ab61999207114fdf935880fabc2e677c Reviewed-on: https://chromium-review.googlesource.com/1116959 Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#571054} -- wpt-commits: 12b9b4c9d40504a6d5df9339d7680a8a89184f18 wpt-pr: 11697 MozReview-Commit-ID: 9VzFxid8Ry8
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/CSS2/abspos/between-float-and-text.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -19444,16 +19444,28 @@
       [
        "/css/CSS2/abspos/abspos-containing-block-initial-009-ref.xht",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/CSS2/abspos/between-float-and-text.html": [
+    [
+     "/css/CSS2/abspos/between-float-and-text.html",
+     [
+      [
+       "/css/reference/ref-filled-green-200px-square.html",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/CSS2/abspos/hypothetical-inline-alone-on-second-line.html": [
     [
      "/css/CSS2/abspos/hypothetical-inline-alone-on-second-line.html",
      [
       [
        "/css/CSS2/abspos/hypothetical-inline-alone-on-second-line-ref.html",
        "=="
       ]
@@ -442668,16 +442680,20 @@
   "css/CSS2/abspos/abspos-containing-block-initial-009e.xht": [
    "a0c2bb8438f6c445403075a97f97e2c47f0cf0da",
    "reftest"
   ],
   "css/CSS2/abspos/abspos-containing-block-initial-009f.xht": [
    "f060b356887b9ceb49be019634657b847bfffe81",
    "reftest"
   ],
+  "css/CSS2/abspos/between-float-and-text.html": [
+   "9594a6d5643108ccd06b2d4a230a1c3c9e4b1bdd",
+   "reftest"
+  ],
   "css/CSS2/abspos/hypothetical-inline-alone-on-second-line-ref.html": [
    "1b59f53e07a23d5adcff80646ed1c2e644590674",
    "support"
   ],
   "css/CSS2/abspos/hypothetical-inline-alone-on-second-line.html": [
    "44f94feef0ef941a7ac86e1c466dc75e729ba647",
    "reftest"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/CSS2/abspos/between-float-and-text.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<title>Auto-positioned abspos after text, before float</title>
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/CSS22/visudet.html#abs-non-replaced-width" title="10.3.7 Absolutely positioned, non-replaced elements">
+<link rel="match" href="../../reference/ref-filled-green-200px-square.html">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="line-height:20px; margin-top:-20px;">
+  &nbsp;
+  <div style="position:absolute; width:200px; height:200px; background:green;"></div>
+  <div style="float:left; margin-top:20px; width:200px; height:200px; background:red;"></div>
+</div>