Bug 1604009 - Remove dead assignments from nsGridRowGroupLayout functions. r=dbaron
authorAlex Henrie <alexhenrie24@gmail.com>
Sun, 15 Dec 2019 18:57:44 +0000
changeset 507028 7e6a4e2214958f95a105a53ee575fde499a0cee2
parent 507027 9ae248d61ed1d5ff0f3aed26521d06060b0f45fa
child 507029 d86fd2d397dcb2e430fffa39aad6a278b123da4e
push id36920
push userdluca@mozilla.com
push dateSun, 15 Dec 2019 21:49:48 +0000
treeherdermozilla-central@7e6a4e221495 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1604009
milestone73.0a1
first release with
nightly linux32
7e6a4e221495 / 73.0a1 / 20191215214948 / files
nightly linux64
7e6a4e221495 / 73.0a1 / 20191215214948 / files
nightly mac
7e6a4e221495 / 73.0a1 / 20191215214948 / files
nightly win32
7e6a4e221495 / 73.0a1 / 20191215214948 / files
nightly win64
7e6a4e221495 / 73.0a1 / 20191215214948 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1604009 - Remove dead assignments from nsGridRowGroupLayout functions. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D57234
layout/xul/grid/nsGridRowGroupLayout.cpp
--- a/layout/xul/grid/nsGridRowGroupLayout.cpp
+++ b/layout/xul/grid/nsGridRowGroupLayout.cpp
@@ -168,17 +168,16 @@ void nsGridRowGroupLayout::CountRowsColu
       // first see if it is a scrollframe. If so walk down into it and get the
       // scrolled child
       nsIFrame* deepChild = nsGrid::GetScrolledBox(child);
 
       nsIGridPart* monument = nsGrid::GetPartFromBox(deepChild);
       if (monument) {
         monument->CountRowsColumns(deepChild, aRowCount, aComputedColumnCount);
         child = nsBox::GetNextXULBox(child);
-        deepChild = child;
         continue;
       }
 
       child = nsBox::GetNextXULBox(child);
 
       // if not a monument. Then count it. It will be a bogus row
       aRowCount++;
     }
@@ -200,17 +199,16 @@ int32_t nsGridRowGroupLayout::BuildRows(
       // first see if it is a scrollframe. If so walk down into it and get the
       // scrolled child
       nsIFrame* deepChild = nsGrid::GetScrolledBox(child);
 
       nsIGridPart* monument = nsGrid::GetPartFromBox(deepChild);
       if (monument) {
         rowCount += monument->BuildRows(deepChild, &aRows[rowCount]);
         child = nsBox::GetNextXULBox(child);
-        deepChild = child;
         continue;
       }
 
       aRows[rowCount].Init(child, true);
 
       child = nsBox::GetNextXULBox(child);
 
       // if not a monument. Then count it. It will be a bogus row