Backed out changeset 317c684efd2d (bug 997908) for mochitest-e10s leaks.
authorRyan VanderMeulen <ryanvm@gmail.com>
Fri, 19 Sep 2014 13:43:02 -0400
changeset 206276 7e06f31a3f01ab65205a9771a79b3a26c3047a22
parent 206275 426bc4161af9cfcfd38c8a11fcdb5e9a6694e22c
child 206277 18fe3472680fe70bb5ac3256bd84042b6af44583
push id27520
push userkwierso@gmail.com
push dateSat, 20 Sep 2014 00:25:19 +0000
treeherdermozilla-central@27253887d2cc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs997908
milestone35.0a1
backs out317c684efd2d1646aca61f3d41a449a4f937db37
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 317c684efd2d (bug 997908) for mochitest-e10s leaks.
xpcom/base/CycleCollectedJSRuntime.cpp
--- a/xpcom/base/CycleCollectedJSRuntime.cpp
+++ b/xpcom/base/CycleCollectedJSRuntime.cpp
@@ -1049,22 +1049,16 @@ CycleCollectedJSRuntime::DeferredFinaliz
   if (!hadThingArray) {
     mDeferredFinalizerTable.Put(aFunc, thingArray);
   }
 }
 
 void
 CycleCollectedJSRuntime::DeferredFinalize(nsISupports* aSupports)
 {
-  // We'll crash here if aSupports is invalid, which is better (more
-  // informative) than crashing in ReleaseSliceNow().  See bug 997908.
-  // This patch should be backed out when bug 997908 gets fixed, or if
-  // it doesn't actually help fix that bug.
-  NS_IF_ADDREF(aSupports);
-  NS_IF_RELEASE(aSupports);
   mDeferredSupports.AppendElement(aSupports);
 }
 
 void
 CycleCollectedJSRuntime::DumpJSHeap(FILE* aFile)
 {
   js::DumpHeapComplete(Runtime(), aFile, js::CollectNurseryBeforeDump);
 }