Bug 1551335 - Update comment on RemoteOuterWindowProxy. r=peterv
authorAndrew McCreight <continuation@gmail.com>
Tue, 14 May 2019 09:13:20 +0000
changeset 473788 7d2d7b47ec349aa71ab0a49a18cfced4b92b7189
parent 473787 0a49234facf2496f920f6ba1ef9e506758466db3
child 473789 54a4320c7206d6a478b23a6a52b1f51b00dcec53
push id36015
push usercbrindusan@mozilla.com
push dateTue, 14 May 2019 21:40:04 +0000
treeherdermozilla-central@f17162f343b6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspeterv
bugs1551335, 1518202
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551335 - Update comment on RemoteOuterWindowProxy. r=peterv The second patch in bug 1518202 made it so that the reference to the browsing context is declared to the cycle collector after all. Differential Revision: https://phabricator.services.mozilla.com/D31001
dom/base/RemoteOuterWindowProxy.cpp
--- a/dom/base/RemoteOuterWindowProxy.cpp
+++ b/dom/base/RemoteOuterWindowProxy.cpp
@@ -14,22 +14,17 @@
 namespace mozilla {
 namespace dom {
 
 /**
  * RemoteOuterWindowProxy is the proxy handler for the WindowProxy objects for
  * Window objects that live in a different process.
  *
  * RemoteOuterWindowProxy holds a BrowsingContext, which is cycle collected.
- * However, RemoteOuterWindowProxy only holds BrowsingContexts that don't have a
- * reference to a docshell, so there's no need to declare the edge from
- * RemoteOuterWindowProxy to its BrowsingContext to the cycle collector.
- *
- * FIXME Verify that this is correct:
- *       https://bugzilla.mozilla.org/show_bug.cgi?id=1516350.
+ * This reference is declared to the cycle collector via NoteChildren().
  */
 
 class RemoteOuterWindowProxy
     : public RemoteObjectProxy<BrowsingContext,
                                Window_Binding::sCrossOriginAttributes,
                                Window_Binding::sCrossOriginMethods> {
  public:
   typedef RemoteObjectProxy Base;