Bug 1344214 Update button in addon install doorhanger r=flod
authorAndrew Swan <aswan@mozilla.com>
Wed, 12 Apr 2017 15:43:34 -0700
changeset 353049 7d1429fe13f7c5c9ebde6f09ad7919799163fab6
parent 352911 423ac063ee983bf1444b0d7190c0d38b40dccf8e
child 353050 16664438cf760d3fbbafa9c4104b28a11ebabbe5
push id31656
push userihsiao@mozilla.com
push dateFri, 14 Apr 2017 09:10:41 +0000
treeherdermozilla-central@cda24082bff8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersflod
bugs1344214
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1344214 Update button in addon install doorhanger r=flod MozReview-Commit-ID: 7bpbpNUfi5h
browser/base/content/browser-addons.js
browser/locales/en-US/chrome/browser/browser.properties
--- a/browser/base/content/browser-addons.js
+++ b/browser/base/content/browser-addons.js
@@ -178,18 +178,18 @@ const gXPInstallObserver = {
     let brandBundle = document.getElementById("bundle_brand");
     let brandShortName = brandBundle.getString("brandShortName");
 
     messageString = PluralForm.get(installInfo.installs.length, messageString);
     messageString = messageString.replace("#1", brandShortName);
     messageString = messageString.replace("#2", installInfo.installs.length);
 
     let action = {
-      label: gNavigatorBundle.getString("addonInstall.acceptButton.label"),
-      accessKey: gNavigatorBundle.getString("addonInstall.acceptButton.accesskey"),
+      label: gNavigatorBundle.getString("addonInstall.acceptButton2.label"),
+      accessKey: gNavigatorBundle.getString("addonInstall.acceptButton2.accesskey"),
       callback: acceptInstallation,
     };
 
     let secondaryAction = {
       label: gNavigatorBundle.getString("addonInstall.cancelButton.label"),
       accessKey: gNavigatorBundle.getString("addonInstall.cancelButton.accesskey"),
       callback: () => {},
     };
@@ -333,18 +333,18 @@ const gXPInstallObserver = {
             break;
           case "removed":
             options.contentWindow = null;
             options.sourceURI = null;
             break;
         }
       };
       action = {
-        label: gNavigatorBundle.getString("addonInstall.acceptButton.label"),
-        accessKey: gNavigatorBundle.getString("addonInstall.acceptButton.accesskey"),
+        label: gNavigatorBundle.getString("addonInstall.acceptButton2.label"),
+        accessKey: gNavigatorBundle.getString("addonInstall.acceptButton2.accesskey"),
         callback: () => {},
       };
       let secondaryAction = {
         label: gNavigatorBundle.getString("addonInstall.cancelButton.label"),
         accessKey: gNavigatorBundle.getString("addonInstall.cancelButton.accesskey"),
         callback: () => {
           for (let install of installInfo.installs) {
             if (install.state != AddonManager.STATE_CANCELLED) {
--- a/browser/locales/en-US/chrome/browser/browser.properties
+++ b/browser/locales/en-US/chrome/browser/browser.properties
@@ -156,18 +156,18 @@ addonPostInstall.okay.key=O
 # http://developer.mozilla.org/en/docs/Localization_and_Plurals
 # Also see https://bugzilla.mozilla.org/show_bug.cgi?id=570012 for mockups
 addonDownloadingAndVerifying=Downloading and verifying add-on…;Downloading and verifying #1 add-ons…
 addonDownloadVerifying=Verifying
 
 addonInstall.unsigned=(Unverified)
 addonInstall.cancelButton.label=Cancel
 addonInstall.cancelButton.accesskey=C
-addonInstall.acceptButton.label=Install
-addonInstall.acceptButton.accesskey=I
+addonInstall.acceptButton2.label=Add
+addonInstall.acceptButton2.accesskey=A
 
 # LOCALIZATION NOTE (addonConfirmInstallMessage,addonConfirmInstallUnsigned):
 # Semicolon-separated list of plural forms. See:
 # http://developer.mozilla.org/en/docs/Localization_and_Plurals
 # #1 is brandShortName
 # #2 is the number of add-ons being installed
 addonConfirmInstall.message=This site would like to install an add-on in #1:;This site would like to install #2 add-ons in #1:
 addonConfirmInstallUnsigned.message=Caution: This site would like to install an unverified add-on in #1. Proceed at your own risk.;Caution: This site would like to install #2 unverified add-ons in #1. Proceed at your own risk.