Bug 1631148 [wpt PR 23082] - Screen Enumeration: Add a placeholder Screen.id to replace Screen.name, a=testonly
authorMike Wasserman <msw@chromium.org>
Tue, 28 Apr 2020 11:35:04 +0000
changeset 527543 7d0fd0d31d2b3bb69ac69f7f2bacfa5d3b8b1f92
parent 527542 16f63baa9864fd619c7b2d4c7a81a8d3dc1b254e
child 527544 b344b9215d483595ac5726aaf149e28dbb387024
push id37368
push userbtara@mozilla.com
push dateFri, 01 May 2020 21:45:51 +0000
treeherdermozilla-central@0f9c5a59e45d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1631148, 23082, 994889, 2155113, 761040
milestone77.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1631148 [wpt PR 23082] - Screen Enumeration: Add a placeholder Screen.id to replace Screen.name, a=testonly Automatic update from web-platform-tests Screen Enumeration: Add a placeholder Screen.id to replace Screen.name Use placeholder ordinal ids for now (0, 1, 2, ...); update tests. TODO: generate per-origin UUIDs that reset when cookies are deleted Test Screen.id values returned via window.getScreens() with: chrome://flags#enable-experimental-web-platform-features OR $ chrome --enable-blink-features=ScreenEnumeration Try https://michaelwasserman.github.io/window-placement-demo Bug: 994889 Test: Automated, Screen.id placeholder values Change-Id: I0c5b18b92fef251211822f3473ea85472a7ee945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155113 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#761040} -- wpt-commits: f8d36b93adcfb21622c935a77427bf99caf3d1e3 wpt-pr: 23082
testing/web-platform/tests/screen_enumeration/getScreens.tentative.https.window.js
--- a/testing/web-platform/tests/screen_enumeration/getScreens.tentative.https.window.js
+++ b/testing/web-platform/tests/screen_enumeration/getScreens.tentative.https.window.js
@@ -20,10 +20,10 @@ promise_test(async testCase => {
   assert_equals(typeof screens[0].availTop, 'number');
   assert_equals(typeof screens[0].left, 'number');
   assert_equals(typeof screens[0].top, 'number');
   assert_equals(typeof screens[0].orientation, 'object');
 
   assert_equals(typeof screens[0].primary, 'boolean');
   assert_equals(typeof screens[0].internal, 'boolean');
   assert_equals(typeof screens[0].scaleFactor, 'number');
-  assert_equals(typeof screens[0].name, 'string');
+  assert_equals(typeof screens[0].id, 'string');
 }, 'self.getScreens returns at least 1 Screen');
\ No newline at end of file