Bug 1390916 - Make .PHONY rule match the actual make targets; r=gps
authorMike Shal <mshal@mozilla.com>
Thu, 10 Aug 2017 14:58:04 -0400
changeset 376037 7c9a5812fc16bf0594e6053dbbeb70be54366f24
parent 376036 b3c14da197758dad66578dd0478d91898b4ff696
child 376038 1b502238070fdbd7b887f2749013c9b59929779c
push id32371
push userarchaeopteryx@coole-files.de
push dateTue, 22 Aug 2017 09:47:47 +0000
treeherdermozilla-central@db2a49c83d53 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1390916
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1390916 - Make .PHONY rule match the actual make targets; r=gps MozReview-Commit-ID: Gy4YrUtaB5H
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -170,17 +170,17 @@ NO_REMOVE=1
 endif
 
 # For an artifact build, _tests will already be partly populated, so run
 # this install manifest with NO_REMOVE set in this case.
 ifdef MOZ_ARTIFACT_BUILDS
 install-_tests: NO_REMOVE=1
 endif
 
-.PHONY: $(addprefix install-,$(subst /,_,$(install_manifests)))
+.PHONY: $(addprefix install-,$(install_manifests))
 $(addprefix install-,$(install_manifests)): install-%: $(install_manifest_depends)
 ifneq (,$(filter FasterMake+RecursiveMake,$(BUILD_BACKENDS)))
 	@# If we're using the hybrid FasterMake/RecursiveMake backend, we want
 	@# to ensure the FasterMake end doesn't have install manifests for the
 	@# same directory, because that would blow up
 	$(if $(wildcard _build_manifests/install/$(subst /,_,$*)),$(if $(wildcard faster/install_$(subst /,_,$*)*),$(error FasterMake and RecursiveMake ends of the hybrid build system want to handle $*)))
 endif
 	$(addprefix $(call py_action,process_install_manifest,$(if $(NO_REMOVE),--no-remove )$*) ,$(wildcard _build_manifests/install/$(subst /,_,$*)))