Bug 1523262 Part 1 - Inform worker we are observing wasm when attaching, r=lsmyth.
authorBrian Hackett <bhackett1024@gmail.com>
Thu, 21 Feb 2019 17:25:14 -1000
changeset 461855 7c6b5ef243de9ac32ef4427424dd5f237050515a
parent 461747 664a5bdd8ab159d09bb75148a59ff5eaeafdabe8
child 461856 4aa22c4f4c7b7ffd113043b6e4662eacb4af9f3c
push id35631
push userrgurzau@mozilla.com
push dateFri, 01 Mar 2019 13:06:03 +0000
treeherdermozilla-central@d4e19870e27f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslsmyth
bugs1523262
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523262 Part 1 - Inform worker we are observing wasm when attaching, r=lsmyth.
devtools/client/debugger/new/src/client/firefox/commands.js
devtools/server/actors/thread.js
--- a/devtools/client/debugger/new/src/client/firefox/commands.js
+++ b/devtools/client/debugger/new/src/client/firefox/commands.js
@@ -353,17 +353,18 @@ function getSourceForActor(actor: ActorI
     throw new Error(`Unknown source actor: ${actor}`);
   }
   return sourceActors[actor];
 }
 
 async function fetchWorkers(): Promise<Worker[]> {
   if (features.windowlessWorkers) {
     const options = {
-      breakpoints
+      breakpoints,
+      observeAsmJS: true
     };
 
     const newWorkerClients = await updateWorkerClients({
       tabTarget,
       debuggerClient,
       threadClient,
       workerClients,
       options
--- a/devtools/server/actors/thread.js
+++ b/devtools/server/actors/thread.js
@@ -274,16 +274,20 @@ const ThreadActor = ActorClassWithSpec(t
       for (const { location, options } of Object.values(request.options.breakpoints)) {
         this.setBreakpoint(location, options);
       }
     }
 
     this.dbg.addDebuggees();
     this.dbg.enabled = true;
 
+    if ("observeAsmJS" in this._options) {
+      this.dbg.allowUnobservedAsmJS = !this._options.observeAsmJS;
+    }
+
     // Notify the parent that we've finished attaching. If this is a worker
     // thread which was paused until attaching, this will allow content to
     // begin executing.
     if (this._parent.onThreadAttached) {
       this._parent.onThreadAttached();
     }
 
     try {