Bug 645982 - Possible error in code [r=mark.finkle]
authorJono X <jdicarlo@mozilla.com>
Mon, 11 Apr 2011 22:30:44 -0400
changeset 67889 7c0c0b502a11
parent 67888 7a8f522fc75a
child 67890 f7a0e34308cd
push id19453
push usermfinkle@mozilla.com
push date2011-04-12 02:35 +0000
treeherdermozilla-central@2a2c474ec4a1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmark
bugs645982
milestone2.2a1pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 645982 - Possible error in code [r=mark.finkle]
browser/app/profile/extensions/testpilot@labs.mozilla.com/modules/feedback.js
--- a/browser/app/profile/extensions/testpilot@labs.mozilla.com/modules/feedback.js
+++ b/browser/app/profile/extensions/testpilot@labs.mozilla.com/modules/feedback.js
@@ -103,17 +103,17 @@ var FeedbackManager = {
      * in 'feedback', 'happy', or 'sad'.
      */
     let ioService = Cc["@mozilla.org/network/io-service;1"]
       .getService(Ci.nsIIOService);
     try {
       let uri = ioService.newURI(url, null, null);
       let path = uri.path;
       if (uri.host == "input.mozilla.com") {
-        if (path.indexOf("feedback" > -1) || path.indexOf("happy" > -1) || path.indexOf("sad" > -1)) {
+        if (path.indexOf("feedback") > -1 || path.indexOf("happy") > -1 || path.indexOf("sad") > -1) {
           return true;
         }
       }
     } catch(e) {
       /* newURI throws an exception if we try to parse urls like "about:config".  (Bug 644582)
        * Those are not the urls we're looking for anyway. */
       return false;
     }