Backed out changeset 76fb9cb1078c (bug 1324463) for failing own crashtest in non-stylo builds. r=backout on a CLOSED TREE
authorSebastian Hengst <archaeopteryx@coole-files.de>
Thu, 12 Oct 2017 09:42:53 +0200
changeset 385845 7bc27566cb27bf9c660e57d8e2f0a7aab45b0c88
parent 385844 381e276f35340f607ad5b5df2f053a6529b1c8cc
child 385846 248c5f4d56d4fba610f1773f45bdbb3948fc32d6
push id32669
push userarchaeopteryx@coole-files.de
push dateThu, 12 Oct 2017 21:58:56 +0000
treeherdermozilla-central@25aad10380b1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1324463
milestone58.0a1
backs out76fb9cb1078c4abf59ac2fc50a95bbb90e6979fa
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 76fb9cb1078c (bug 1324463) for failing own crashtest in non-stylo builds. r=backout on a CLOSED TREE
dom/base/ShadowRoot.cpp
dom/base/crashtests/1324463.html
dom/base/crashtests/crashtests.list
--- a/dom/base/ShadowRoot.cpp
+++ b/dom/base/ShadowRoot.cpp
@@ -503,17 +503,17 @@ ShadowRoot::ContentAppended(nsIDocument*
 
   // Watch for new nodes added to the pool because the node
   // may need to be added to an insertion point.
   nsIContent* currentChild = aFirstNewContent;
   while (currentChild) {
     // Add insertion point to destination insertion points of fallback content.
     if (nsContentUtils::IsContentInsertionPoint(aContainer)) {
       HTMLContentElement* content = HTMLContentElement::FromContent(aContainer);
-      if (content && content->MatchedNodes().IsEmpty()) {
+      if (content->MatchedNodes().IsEmpty()) {
         currentChild->DestInsertionPoints().AppendElement(aContainer);
       }
     }
 
     if (IsPooledNode(currentChild, aContainer, GetHost())) {
       DistributeSingleNode(currentChild);
     }
 
deleted file mode 100644
--- a/dom/base/crashtests/1324463.html
+++ /dev/null
@@ -1,16 +0,0 @@
-<!DOCTYPE html>
-<html>
-<script>
-// requires: user_pref("dom.webcomponents.enabled", true);
-addEventListener("DOMContentLoaded", function(){
-  let o_0 = document.createElement("span").createShadowRoot();
-  let o_1 = document.createElementNS("http://www.mozilla.org/xbl", "binding");
-  let o_2 = document.createElementNS("http://www.mozilla.org/xbl", "children");
-  let o_3 = document.createTextNode("");
-  o_0.appendChild(o_1);
-  o_1.appendChild(o_2);
-  o_2.appendChild(o_3);
-  o_2.removeChild(o_3);
-});
-</script>
-</html>
--- a/dom/base/crashtests/crashtests.list
+++ b/dom/base/crashtests/crashtests.list
@@ -226,9 +226,8 @@ load 1383478.html
 load 1383780.html
 pref(clipboard.autocopy,true) load 1385272-1.html
 load 1393806.html
 load 1396466.html
 load 1400701.html
 load 1403377.html
 load 1405771.html
 load 1406109-1.html
-pref(dom.webcomponents.enabled,true) load 1324463.html