Bug 796526 - stop spewing errors re SysGetModuleInfo64 in debug builds. r=dbaron
authorMark Hammond <mhammond@skippinet.com.au>
Tue, 16 Oct 2012 11:26:35 +1100
changeset 110354 7b582c09463b12f1f47242e62a94dafb102bc78e
parent 110353 a8a4f26cbb7855ed2b4707452a36131af5d4a890
child 110355 14f09c2fb04ccb82a478ac23fabf9c79ab9bc248
push id23680
push useremorley@mozilla.com
push dateTue, 16 Oct 2012 08:09:24 +0000
treeherdermozilla-central@8f145599e4bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs796526
milestone19.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 796526 - stop spewing errors re SysGetModuleInfo64 in debug builds. r=dbaron
xpcom/base/nsStackWalk.cpp
--- a/xpcom/base/nsStackWalk.cpp
+++ b/xpcom/base/nsStackWalk.cpp
@@ -647,18 +647,16 @@ BOOL SymGetModuleInfoEspecial64(HANDLE a
         enumRes = EnumerateLoadedModules64(aProcess, (PENUMLOADED_MODULES_CALLBACK64)callbackEspecial64, (PVOID)&aAddr);
         if (FALSE != enumRes)
         {
             /*
              * One final go.
              * If it fails, then well, we have other problems.
              */
             retval = SymGetModuleInfo64(aProcess, aAddr, aModuleInfo);
-            if (!retval)
-                PrintError("SymGetModuleInfo64");
         }
     }
 
     /*
      * If we got module info, we may attempt line info as well.
      * We will not report failure if this does not work.
      */
     if (FALSE != retval && nullptr != aLineInfo) {