Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r=jya
authorBryce Van Dyk <bvandyk@mozilla.com>
Mon, 25 Mar 2019 19:37:39 +0000
changeset 466007 7b0a87b6f9402fd9377da61aa839541e3ef192f1
parent 466006 f5dd833c3b60b3365d2c49d930748e33a22651b6
child 466008 38cd4d2c99a11ee976d0491c5a2fecab92418678
push id35758
push userrgurzau@mozilla.com
push dateTue, 26 Mar 2019 09:51:47 +0000
treeherdermozilla-central@4572f6055a6a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1538253
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r=jya We had a stray `&&` where a `==` should have been. Differential Revision: https://phabricator.services.mozilla.com/D24526
dom/media/platforms/agnostic/VPXDecoder.h
--- a/dom/media/platforms/agnostic/VPXDecoder.h
+++ b/dom/media/platforms/agnostic/VPXDecoder.h
@@ -103,18 +103,19 @@ class VPXDecoder : public MediaDataDecod
           1             0         YUV 4:2:2
           1             1         YUV 4:2:0
     */
     bool mSubSampling_x = true;
     bool mSubSampling_y = true;
 
     bool IsCompatible(const VPXStreamInfo& aOther) const {
       return mImage == aOther.mImage && mProfile == aOther.mProfile &&
-             mBitDepth == aOther.mBitDepth && mSubSampling_x &&
-             aOther.mSubSampling_x && mSubSampling_y == aOther.mSubSampling_y;
+             mBitDepth == aOther.mBitDepth &&
+             mSubSampling_x == aOther.mSubSampling_x &&
+             mSubSampling_y == aOther.mSubSampling_y;
     }
   };
 
   static bool GetStreamInfo(Span<const uint8_t> aBuffer, VPXStreamInfo& aInfo,
                             Codec aCodec);
 
  private:
   ~VPXDecoder();