Bug 1570207: Part 2 - Remove skip-if/fail-if annotations for CanAccessItem failures. r=nika
authorKris Maglione <maglione.k@gmail.com>
Wed, 31 Jul 2019 18:54:54 -0700
changeset 485829 783c0e44c713d31bdf14dd84bdded192171343d1
parent 485828 7bfc8b1c626dcf3cf146fafc606fbe0cf8064d1a
child 485830 f742215abea862a82599cc6869b970d487cf8f29
push id36374
push userrmaries@mozilla.com
push dateFri, 02 Aug 2019 03:53:17 +0000
treeherdermozilla-central@4748c006ae7b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnika
bugs1570207
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1570207: Part 2 - Remove skip-if/fail-if annotations for CanAccessItem failures. r=nika MANUAL PUSH: Landing partial patch stack Differential Revision: https://phabricator.services.mozilla.com/D39992
dom/base/test/mochitest.ini
dom/tests/mochitest/dom-level0/mochitest.ini
dom/tests/mochitest/localstorage/mochitest.ini
dom/tests/mochitest/sessionstorage/mochitest.ini
dom/tests/mochitest/whatwg/mochitest.ini
js/xpconnect/tests/mochitest/mochitest.ini
--- a/dom/base/test/mochitest.ini
+++ b/dom/base/test/mochitest.ini
@@ -873,17 +873,16 @@ skip-if = fission && (debug || asan) # C
 [test_window_define_nonconfigurable.html]
 [test_window_define_symbol.html]
 [test_window_element_enumeration.html]
 [test_window_enumeration.html]
 [test_window_extensible.html]
 [test_window_indexing.html]
 [test_window_keys.html]
 [test_window_named_frame_enumeration.html]
-fail-if = fission
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_window_own_props.html]
 [test_window_proto.html]
 [test_writable-replaceable.html]
 [test_x-frame-options.html]
 fail-if = fission
 skip-if = toolkit == 'android' && debug && !is_fennec
 [test_youtube_flash_embed.html]
--- a/dom/tests/mochitest/dom-level0/mochitest.ini
+++ b/dom/tests/mochitest/dom-level0/mochitest.ini
@@ -8,25 +8,22 @@ support-files =
   idn_child.html
   innerWidthHeight_script.html
   iframe1_location_setters.html
   iframe2_location_setters.html
   iframe3_location_setters.html
   file_test_background_loading_iframes.html
 
 [test_crossdomainprops.html]
-skip-if = fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
 [test_innerWidthHeight_script.html]
 [test_location.html]
 fail-if = fission
 [test_location_framed.html]
 [test_location_getters.html]
 [test_location_sandboxed.html]
 [test_location_setters.html]
 fail-if = fission
 [test_setting_document.domain_idn.html]
-skip-if = fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
 fail-if = fission
+skip-if = fission && debug # Causes shutdown leaks under Fission.
 [test_setting_document.domain_to_shortened_ipaddr.html]
-skip-if = fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
-fail-if = fission
 [test_separate_post_message_queue.html]
 [test_background_loading_iframes.html]
--- a/dom/tests/mochitest/localstorage/mochitest.ini
+++ b/dom/tests/mochitest/localstorage/mochitest.ini
@@ -22,17 +22,16 @@ support-files =
 [test_brokenUTF-16.html]
 [test_bug600307-DBOps.html]
 [test_bug746272-1.html]
 [test_bug746272-2.html]
 skip-if = os == "android" || verify # bug 962029
 [test_cookieBlock.html]
 [test_embededNulls.html]
 [test_keySync.html]
-skip-if = fission # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
 [test_localStorageBase.html]
 skip-if = e10s
 [test_localStorageBaseSessionOnly.html]
 [test_localStorageCookieSettings.html]
 skip-if = fission && debug # Crashes: @ std::_Function_handler<void (mozilla::Tuple<nsresult, mozilla::dom::PBrowserBridgeParent*>&&), mozilla::dom::WindowGlobalParent::ChangeFrameRemoteness(mozilla::dom::BrowsingContext*, nsTSubstring<char16_t> const&, unsigned long, mozilla::ErrorResult&)::$_2>::_M_invoke(std::_Any_data const&, mozilla::Tuple<nsresult, mozilla::dom::PBrowserBridgeParent*>&&)
 [test_localStorageEnablePref.html]
 [test_localStorageKeyOrder.html]
 [test_localStorageOriginsDiff.html]
@@ -42,19 +41,17 @@ skip-if = fission
 [test_localStorageOriginsEquals.html]
 skip-if = fission || toolkit == 'android'
 [test_localStorageOriginsPortDiffs.html]
 skip-if = fission
 [test_localStorageOriginsSchemaDiffs.html]
 skip-if = fission || toolkit == 'android' #TIMED_OUT
 [test_localStorageQuota.html]
 fail-if = fission
-skip-if =
-  toolkit == 'android' || #TIMED_OUT
-  fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
+skip-if = toolkit == 'android' #TIMED_OUT
 [test_localStorageQuotaSessionOnly.html]
 skip-if = toolkit == 'android' || (verify && (os == 'linux' || os == 'mac' || os == 'win')) #TIMED_OUT
 [test_localStorageQuotaSessionOnly2.html]
 skip-if = true # bug 1347690
 [test_localStorageReplace.html]
 fail-if = fission
 skip-if = toolkit == 'android'
 [test_storageConstructor.html]
--- a/dom/tests/mochitest/sessionstorage/mochitest.ini
+++ b/dom/tests/mochitest/sessionstorage/mochitest.ini
@@ -9,15 +9,12 @@ support-files =
   interOriginTest.js
 
 [test_sessionStorageBase.html]
 [test_sessionStorageBaseSessionOnly.html]
 [test_sessionStorageClone.html]
 fail-if = fission
 skip-if = toolkit == 'android'
 [test_sessionStorageHttpHttps.html]
-fail-if = fission
-skip-if =
-  toolkit == 'android' || #TIMED_OUT
-  fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
+skip-if = toolkit == 'android' #TIMED_OUT
 [test_sessionStorageReplace.html]
 fail-if = fission
 [test_sessionStorageUsage.html]
--- a/dom/tests/mochitest/whatwg/mochitest.ini
+++ b/dom/tests/mochitest/whatwg/mochitest.ini
@@ -22,34 +22,32 @@ skip-if = fission && debug # Causes shut
 [test_MessageEvent_dispatchToOther.html]
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_MessageEvent.html]
 [test_postMessage_basehref.html]
 [test_postMessage_closed.html]
 skip-if = toolkit == 'android' #bug 894914 - wrong data - got FAIL, expected message
 [test_postMessage_hash.html]
 [test_postMessage.html]
-skip-if = fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
 fail-if = fission
 [test_postMessage_idn.xhtml]
 fail-if = fission
 [test_postMessage_joined.html]
 fail-if = fission
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_postMessage_onOther.html]
 fail-if = fission
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_postMessage_origin.xhtml]
 fail-if = fission
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_postMessage_override.html]
 skip-if = fission
 [test_postMessage_special.xhtml]
 [test_postMessage_structured_clone.html]
-skip-if = fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
 fail-if = fission
 [test_postMessage_throw.html]
 fail-if = fission
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_postMessage_transfer.html]
 fail-if = fission
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_postMessage_userpass.html]
--- a/js/xpconnect/tests/mochitest/mochitest.ini
+++ b/js/xpconnect/tests/mochitest/mochitest.ini
@@ -94,17 +94,16 @@ fail-if = fission
 [test_bug862380.html]
 [test_bug865260.html]
 [test_bug870423.html]
 fail-if = fission
 skip-if = fission && (debug || asan) # Causes shutdown leaks under Fission.
 [test_bug871887.html]
 [test_bug912322.html]
 [test_bug916945.html]
-skip-if = fission && debug # Crashes: @ nsDocShell::CanAccessItem(nsIDocShellTreeItem*, nsIDocShellTreeItem*, bool)
 fail-if = fission
 [test_bug92773.html]
 [test_bug940783.html]
 fail-if = fission
 [test_bug965082.html]
 fail-if = fission
 [test_bug960820.html]
 [test_bug986542.html]