Bug 1362505. Correctly set the transforms on all DrawTargets. r=lsalzman
authorJeff Muizelaar <jmuizelaar@mozilla.com>
Fri, 05 May 2017 23:51:35 -0400
changeset 357045 7836c4892b15f65619020d13afb9c61f701d1c61
parent 357044 ec5a1251f38dfe14b902554beb2752d32c6e3636
child 357046 02f1a6c574cf67ee1aff1878227ebdf25e29e235
push id31780
push userkwierso@gmail.com
push dateMon, 08 May 2017 20:34:47 +0000
treeherdermozilla-central@bab7046ee2d8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslsalzman
bugs1362505
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1362505. Correctly set the transforms on all DrawTargets. r=lsalzman I suppose this got worse when we started using multiple DrawTargets. But let's just do the right thing and not special case transforms.
gfx/2d/InlineTranslator.cpp
--- a/gfx/2d/InlineTranslator.cpp
+++ b/gfx/2d/InlineTranslator.cpp
@@ -51,23 +51,18 @@ InlineTranslator::TranslateRecording(std
       RecordedEvent::LoadEventFromStream(aRecording,
       static_cast<RecordedEvent::EventType>(eventType)));
 
     // Make sure that the whole event was read from the stream successfully.
     if (!aRecording.good() || !recordedEvent) {
       return false;
     }
 
-    if (recordedEvent->GetType() == RecordedEvent::SETTRANSFORM) {
-      RecordedSetTransform* event = static_cast<RecordedSetTransform*>(recordedEvent.get());
-      mBaseDT->SetTransform(event->mTransform * mBaseTransform);
-    } else {
-      if (!recordedEvent->PlayEvent(this)) {
-        return false;
-      }
+    if (!recordedEvent->PlayEvent(this)) {
+      return false;
     }
 
     ReadElement(aRecording, eventType);
   }
 
   return true;
 }