Bug 895702 - Remove unnecessary bytes length check. r=rnewman
authorBrian Nicholson <bnicholson@mozilla.com>
Mon, 29 Jul 2013 16:32:01 -0400
changeset 143476 769616494a6ec1b1a339c8fca337a564dbe902f7
parent 143475 a960b4cb3378005c38e2642d349f8480f43e46e6
child 143477 0a243d3f33c2b922ea6e267fe5553e5ecc4485ed
push id25130
push userlrocha@mozilla.com
push dateWed, 21 Aug 2013 09:41:27 +0000
treeherdermozilla-central@b2486721572e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrnewman
bugs895702
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 895702 - Remove unnecessary bytes length check. r=rnewman
mobile/android/base/home/HomeFragment.java
--- a/mobile/android/base/home/HomeFragment.java
+++ b/mobile/android/base/home/HomeFragment.java
@@ -115,17 +115,17 @@ abstract class HomeFragment extends Frag
             case R.id.home_add_to_launcher: {
                 if (info.url == null) {
                     Log.e(LOGTAG, "Can't add to home screen because URL is null");
                     break;
                 }
 
                 // FIXME: bug 897772
                 Bitmap bitmap = null;
-                if (info.favicon != null && info.favicon.length > 0) {
+                if (info.favicon != null) {
                     bitmap = BitmapUtils.decodeByteArray(info.favicon);
                 }
 
                 String shortcutTitle = TextUtils.isEmpty(info.title) ? info.url.replaceAll(REGEX_URL_TO_TITLE, "") : info.title;
                 GeckoAppShell.createShortcut(shortcutTitle, info.url, bitmap, "");
                 return true;
             }