Bug 1525739 - Remove XUL grid layout from browser/base/content/sanitize.xul. r=Gijs
authorTim Nguyen <ntim.bugs@gmail.com>
Thu, 07 Feb 2019 22:12:42 +0000
changeset 457665 760191b55ab399d033c0d24293112514e3c84cde
parent 457664 cba914a4f50cb65b25d46dc325eaba9b65205687
child 457666 d599d1a73a3a87bd11763c0cc52c0af45c67e8dc
push id35516
push userrmaries@mozilla.com
push dateFri, 08 Feb 2019 04:23:26 +0000
treeherdermozilla-central@d599d1a73a3a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1525739
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1525739 - Remove XUL grid layout from browser/base/content/sanitize.xul. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D18885
browser/base/content/sanitize.xul
--- a/browser/base/content/sanitize.xul
+++ b/browser/base/content/sanitize.xul
@@ -68,58 +68,46 @@
     </hbox>
     <spacer flex="1"/>
   </vbox>
 
   <separator class="thin"/>
 
   <groupbox>
     <label><html:h2 data-l10n-id="history-section-label"/></label>
-    <grid flex="1">
-      <columns>
-        <column data-l10n-id="sanitize-prefs-style" data-l10n-attrs="style"/>
-        <column flex="1"/>
-      </columns>
-      <rows>
-        <row>
-          <checkbox data-l10n-id="item-history-and-downloads"
-                    preference="privacy.cpd.history"
-                    onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
-          <checkbox data-l10n-id="item-cookies"
-                    preference="privacy.cpd.cookies"
-                    onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
-        </row>
-        <row>
-          <checkbox data-l10n-id="item-active-logins"
-                    preference="privacy.cpd.sessions"
-                    onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
-          <checkbox data-l10n-id="item-cache"
-                    preference="privacy.cpd.cache"
-                    onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
-        </row>
-        <row>
-          <checkbox data-l10n-id="item-form-search-history"
-                    preference="privacy.cpd.formdata"
-                    onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
-        </row>
-      </rows>
-    </grid>
+    <hbox>
+      <vbox data-l10n-id="sanitize-prefs-style" data-l10n-attrs="style">
+        <checkbox data-l10n-id="item-history-and-downloads"
+                  preference="privacy.cpd.history"
+                  onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
+        <checkbox data-l10n-id="item-active-logins"
+                  preference="privacy.cpd.sessions"
+                  onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
+        <checkbox data-l10n-id="item-form-search-history"
+                  preference="privacy.cpd.formdata"
+                  onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
+      </vbox>
+      <vbox flex="1">
+        <checkbox data-l10n-id="item-cookies"
+                  preference="privacy.cpd.cookies"
+                  onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
+        <checkbox data-l10n-id="item-cache"
+                  preference="privacy.cpd.cache"
+                  onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
+      </vbox>
+    </hbox>
   </groupbox>
   <groupbox>
     <label><html:h2 data-l10n-id="data-section-label"/></label>
-    <grid flex="1">
-      <columns>
-        <column data-l10n-id="sanitize-prefs-style" data-l10n-attrs="style"/>
-        <column flex="1"/>
-      </columns>
-      <rows>
-        <row>
-          <checkbox data-l10n-id="item-site-preferences"
-                    preference="privacy.cpd.siteSettings"
-                    onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
-          <checkbox data-l10n-id="item-offline-apps"
-                    preference="privacy.cpd.offlineApps"
-                    onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
-        </row>
-      </rows>
-    </grid>
+    <hbox>
+      <box data-l10n-id="sanitize-prefs-style" data-l10n-attrs="style">
+        <checkbox data-l10n-id="item-site-preferences"
+                  preference="privacy.cpd.siteSettings"
+                  onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
+      </box>
+      <box flex="1">
+        <checkbox data-l10n-id="item-offline-apps"
+                  preference="privacy.cpd.offlineApps"
+                  onsyncfrompreference="return gSanitizePromptDialog.onReadGeneric();"/>
+      </box>
+    </hbox>
   </groupbox>
 </dialog>