Bug 932796: Fix ThrowError call (r=nmatsakis).
authorFelix S. Klock II <pnkfelix@pnkfx.org>
Thu, 31 Oct 2013 15:36:46 +0100
changeset 153611 75d5fed1950e0e0cbad884df0d77d1579c4d5f50
parent 153610 94032114aaf5f2a8e41811e86f02aa367e15325a
child 153612 cbd97422f174c7a5fcef097886ca5f9feebb9a79
push id25596
push userryanvm@gmail.com
push dateTue, 05 Nov 2013 20:28:59 +0000
treeherdermozilla-central@8b89e6626298 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnmatsakis
bugs932796
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 932796: Fix ThrowError call (r=nmatsakis).
js/src/builtin/TypedObject.js
--- a/js/src/builtin/TypedObject.js
+++ b/js/src/builtin/TypedObject.js
@@ -446,17 +446,17 @@ function HandleMove(handle, obj, ...path
   HandleMoveInternal(handle, obj, path);
 }
 
 function HandleMoveInternal(handle, obj, path) {
   assert(ObjectIsTypedHandle(handle),
          "HandleMoveInternal: not typed handle");
 
   if (!IsObject(obj) || !ObjectIsTypedDatum(obj))
-    ThrowError(JSMSG_INCOMPATIBLE_PROTO);
+    ThrowError(JSMSG_INCOMPATIBLE_PROTO, "Handle", "set", "value");
 
   var ptr = TypedObjectPointer.fromTypedDatum(obj);
   for (var i = 0; i < path.length; i++)
     ptr.moveTo(path[i]);
 
   // Check that the new destination is equivalent to the handle type.
   if (ptr.typeRepr !== DATUM_TYPE_REPR(handle))
     ThrowError(JSMSG_TYPEDOBJECT_HANDLE_BAD_TYPE);