Bug 1544843 - Remove irrelevant Grip test. r=nchevobbe.
authorGettyOrawo <gettyorawo@gmail.com>
Tue, 16 Apr 2019 16:31:03 +0000
changeset 469704 74433b3e4a6f
parent 469703 637a1287318c
child 469705 eb1553deea2f
push id35879
push usernerli@mozilla.com
push dateTue, 16 Apr 2019 22:01:48 +0000
treeherdermozilla-central@12a60898fdc1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1544843
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1544843 - Remove irrelevant Grip test. r=nchevobbe. Porting over from: https://github.com/firefox-devtools/debugger/commit/e2f78a982b21ecaa380d0958b1e9a5213f7904db Differential Revision: https://phabricator.services.mozilla.com/D27737
devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip.js
--- a/devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip.js
+++ b/devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip.js
@@ -259,37 +259,16 @@ describe("Grip - Object with more than l
     const props = Array.from({ length: maxLengthMap.get(MODE.LONG) }).map(
       (item, i) => `p${i}: "${i}"`
     );
     const longOutput = `Object { ${props.join(", ")}, … }`;
     expect(renderRep({ mode: MODE.LONG }).text()).toBe(longOutput);
   });
 });
 
-describe("Grip - Object with uninteresting properties", () => {
-  // Test object: `{a: undefined, b: undefined, c: "c", d: 1}`
-  const object = stubs.get("testUninterestingProps");
-
-  it("correctly selects Grip Rep", () => {
-    expect(getRep(object)).toBe(Grip.rep);
-  });
-
-  it.skip("renders as expected", () => {
-    // @TODO This is broken at the moment.
-    // See https://bugzilla.mozilla.org/show_bug.cgi?id=1276376
-    const renderRep = props => shallowRenderRep(object, props);
-    const defaultOutput = 'Object {c: "c", d: 1, a: undefined, more...}';
-
-    expect(renderRep({ mode: undefined }).text()).toBe(defaultOutput);
-    expect(renderRep({ mode: MODE.TINY }).text()).toBe("{…}");
-    expect(renderRep({ mode: MODE.SHORT }).text()).toBe(defaultOutput);
-    expect(renderRep({ mode: MODE.LONG }).text()).toBe(defaultOutput);
-  });
-});
-
 describe("Grip - Object with non-enumerable properties", () => {
   // Test object: `Object.defineProperty({}, "foo", {enumerable : false});`
   const object = stubs.get("testNonEnumerableProps");
 
   it("correctly selects Grip Rep", () => {
     expect(getRep(object)).toBe(Grip.rep);
   });